[GitHub] TaoLv commented on issue #10215: Avoid MKLDNN in-place data conversion in NDArray synchronously

[GitBox <gi...@apache.org>]

TaoLv commented on issue #10215: Avoid MKLDNN in-place data conversion in NDArray synchronously
URL: https://github.com/apache/incubator-mxnet/pull/10215#issuecomment-375836486
 
 
   One minor suggestion: why not implement reorder as a operator and dependency check to dependency engine?
   
   Sent from my iPhone
   
   On 24 Mar 2018, at 2:57 AM, Da Zheng <no...@github.com>> wrote:
   
   
   @eric-haibin-lin</eric-haibin-lin> @piiswrong</piiswrong> let's remove all functions that perform in-place data layout conversion on an NDArray synchronously. If in the future someone calls data() on an MKLDNN NDArray, they'll see an error message. What do you think?
   
   —
   You are receiving this because you are subscribed to this thread.
   Reply to this email directly, view it on GitHub<https://github.com/apache/incubator-mxnet/pull/10215#issuecomment-375767026>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AVZehk-eg4dFSEJF-nEL35EjrbzqdTj7ks5thUWWgaJpZM4S4AM1>.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services