You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/05/29 20:57:50 UTC

[GitHub] [incubator-nuttx] patacongo commented on pull request #1148: tools/incdir.c: Add faster, C version of incdir.sh

patacongo commented on pull request #1148:
URL: https://github.com/apache/incubator-nuttx/pull/1148#issuecomment-636189025


   @xiaoxiang781216 @yamt Perhaps you could help verify this change on Linux and macOS.  I am still waiting for feedback from Johannes on his serious build slowdown, but I think this will help build time significantly, but mostly on Windows based platforms that have problems with fork().  If you could verify that this change is good for you, I can do the final integration into the build system.
   
   Or you can if you want to.  It would need:
   
   1. A new target in Makefile.unix and Makefile.win like:
   
       tools/mkdeps$(HOSTEXEEXT):
               $(Q) $(MAKE) -C tools -f Makefile.host TOPDIR="$(TOPDIR)" mkdeps$(HOSTEXEEXT)
   
   2. And a change in Config.mk to use incdir$(HOSTEXEEXT) instead on incdir.sh
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org