You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2022/03/13 03:16:24 UTC

[GitHub] [zookeeper] tisonkun opened a new pull request #1837: ZOOKEEPER-XXXX: Merge readOnly field into ConnectRequest and Response

tisonkun opened a new pull request #1837:
URL: https://github.com/apache/zookeeper/pull/1837


   According to [this comment in ZOOKEEPER-102](https://issues.apache.org/jira/browse/ZOOKEEPER-102?focusedCommentId=16977000&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16977000) I introduce a `Protocol` abstraction and going to moving all wire protocol concept into `cnxn` and this scope, so that client and server's business logics handle only deserialized/real record.
   
   cc @eolivelli @maoling @Randgalt 
   
   This supersedes #1832.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] tisonkun edited a comment on pull request #1837: ZOOKEEPER-XXXX: Merge readOnly field into ConnectRequest and Response

Posted by GitBox <gi...@apache.org>.
tisonkun edited a comment on pull request #1837:
URL: https://github.com/apache/zookeeper/pull/1837#issuecomment-1066095370


   > why the new server will be compatible with old clients
   
   An old client sends connect request without readonly field, and the new server read that payload with an exception fail to read readonly field, so it switch to zk 3.3 protocol.
   
   An old client receives connect response with readonly field from the new server, which is consumed from the wire by the leading length field, and the client doesn't parse it actually, which does no harm.
   
   @eolivelli is there any other communication round you find subtle to understand?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] tisonkun commented on pull request #1837: ZOOKEEPER-4492: Merge readOnly field into ConnectRequest and Response

Posted by GitBox <gi...@apache.org>.
tisonkun commented on pull request #1837:
URL: https://github.com/apache/zookeeper/pull/1837#issuecomment-1066241810


   @eolivelli logged as ZOOKEEPER-4492. For "commit message", I've updated the PR title. Shall I squash all commits into "ZOOKEEPER-4492: ..." also?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] tisonkun commented on pull request #1837: ZOOKEEPER-XXXX: Merge readOnly field into ConnectRequest and Response

Posted by GitBox <gi...@apache.org>.
tisonkun commented on pull request #1837:
URL: https://github.com/apache/zookeeper/pull/1837#issuecomment-1066095370


   > why the new server will be compatible with old clients
   
   An old client sends connect request without readonly field, and the new server read that payload with an exception fail to read readonly field, so it switch to zk 3.3 protocol.
   
   An old client receives connect response with readonly field from the new server, which is consumer by the leading length field, and the client doesn't parse it actually, which does no harm.
   
   @eolivelli is there any other communication round you find subtle to understand?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] eolivelli commented on pull request #1837: ZOOKEEPER-XXXX: Merge readOnly field into ConnectRequest and Response

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1837:
URL: https://github.com/apache/zookeeper/pull/1837#issuecomment-1066135437


   Please log a JiRA and update the commit message


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org