[GitHub] [airflow] eumiro commented on a diff in pull request #33295: Refactor: Simplify code in scripts

["eumiro (via GitHub)" <gi...@apache.org>]

eumiro commented on code in PR #33295:
URL: https://github.com/apache/airflow/pull/33295#discussion_r1291221587


##########
scripts/ci/runners/sync_authors.py:
##########
@@ -42,15 +42,8 @@
 req = requests.get(AUTHORS)
 author_list = toml.loads(req.text)
 
-author_set = set()
-for membership in author_list:
-    author_set.update([author for author in author_list[membership]])
-
-authors = ""
-for author in sorted(author_set):
-    authors += f'            "{author}",\n'
-
-authors = authors[:-2]
+author_set = set().union(*author_list.values())
+authors = ",\n".join(f'            "{author}"' for author in author_set)

Review Comment:
   Looks like https://github.com/apache/airflow-ci-infra/pull/58 removed that authors file anyway.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org