[GitHub] [pulsar-client-cpp] BewareMyPower opened a new pull request, #225: Fix possible crash caused by MessageId::getTopicName

["BewareMyPower (via GitHub)" <gi...@apache.org>]

BewareMyPower opened a new pull request, #225:
URL: https://github.com/apache/pulsar-client-cpp/pull/225

   ### Motivation
   
   Currently if a `MessageId` does not have a topic name, the `getTopicName` method will dereference a null pointer, which leads to a crash. This case usually happens when an invalid message is acknowledged, like
   https://github.com/apache/pulsar-client-cpp/issues/224.
   
   ### Modifications
   
   Return the const reference to an empty string in `getTopicName` when the inner topic name field is a null pointer. Then, return `ResultOperationNotSupported` when acknowledging such invalid messages.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-cpp] BewareMyPower merged pull request #225: Fix possible crash caused by MessageId::getTopicName

["BewareMyPower (via GitHub)" <gi...@apache.org>]

BewareMyPower merged PR #225:
URL: https://github.com/apache/pulsar-client-cpp/pull/225


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org