You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/03/17 22:33:53 UTC

Review Request 44981: Marked some private `json` functions as `static`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44981/
-----------------------------------------------------------

Review request for mesos and Michael Park.


Repository: mesos


Description
-------

Marked some private `json` functions as `static`.


Diffs
-----

  src/master/http.cpp b47ab7cc86c0a56a81815a98bd63f37a1175ba7f 
  src/slave/http.cpp 4eb1fafdfa72094511b0b2684a3c2705bd8c7c5e 

Diff: https://reviews.apache.org/r/44981/diff/


Testing
-------

make check


Thanks,

Neil Conway


Re: Review Request 44981: Marked some private `json` functions as `static`.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44981/#review125334
-----------------------------------------------------------



Bad review!

Reviews applied: [44981, 43911]

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.

- Mesos ReviewBot


On March 17, 2016, 9:33 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44981/
> -----------------------------------------------------------
> 
> (Updated March 17, 2016, 9:33 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Marked some private `json` functions as `static`.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp b47ab7cc86c0a56a81815a98bd63f37a1175ba7f 
>   src/slave/http.cpp 4eb1fafdfa72094511b0b2684a3c2705bd8c7c5e 
> 
> Diff: https://reviews.apache.org/r/44981/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Re: Review Request 44981: Marked some private `json` functions as `static`.

Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44981/#review125283
-----------------------------------------------------------


Ship it!




Ship It!

- Michael Park


On March 17, 2016, 9:33 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44981/
> -----------------------------------------------------------
> 
> (Updated March 17, 2016, 9:33 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Marked some private `json` functions as `static`.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp b47ab7cc86c0a56a81815a98bd63f37a1175ba7f 
>   src/slave/http.cpp 4eb1fafdfa72094511b0b2684a3c2705bd8c7c5e 
> 
> Diff: https://reviews.apache.org/r/44981/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>