[GitHub] [incubator-doris] adonis0147 commented on a diff in pull request #9483: [style] Use clang-format to sort includes

[GitBox <gi...@apache.org>]

adonis0147 commented on code in PR #9483:
URL: https://github.com/apache/incubator-doris/pull/9483#discussion_r869025564


##########
be/src/common/status.h:
##########
@@ -5,13 +5,13 @@
 #pragma once
 
 #include <fmt/format.h>
+#include <glog/logging.h>
+
+#include <boost/stacktrace.hpp>

Review Comment:
   Our clang-format style is based on [Google Code Style](https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes) (`BasedOnStyle: Google` in `.clang-format`). The rules doesn't apply lexical order simply.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org