You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Chengwei Yang <ch...@gmail.com> on 2014/04/16 06:35:05 UTC
Review Request 20403: Add all model() declaration into src/common/http.hpp
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20403/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Repository: mesos-git
Description
-------
Add all model() declaration into src/common/http.hpp
There are four overloading function model() but only three of them
declared in src/common/http.hpp and used.
In case the last one will be used in future, declare it in
src/common/http.hpp too.
Diffs
-----
src/common/http.hpp 717bbe99f2ec51a2d1b90730eb19cd54cc82b897
Diff: https://reviews.apache.org/r/20403/diff/
Testing
-------
make passed
Thanks,
Chengwei Yang
Re: Review Request 20403: Add all model() declaration into
src/common/http.hpp
Posted by Dominic Hamon <dh...@twopensource.com>.
> On April 16, 2014, 9:23 a.m., Dominic Hamon wrote:
> > this is used in the cpp only so there's no need for it to be added to the public header.
>
> Chengwei Yang wrote:
> Yeah, I saw that, maybe make it a static function is better.
i think that would be better, yes.
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20403/#review40562
-----------------------------------------------------------
On April 15, 2014, 9:35 p.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20403/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 9:35 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Add all model() declaration into src/common/http.hpp
>
> There are four overloading function model() but only three of them
> declared in src/common/http.hpp and used.
>
> In case the last one will be used in future, declare it in
> src/common/http.hpp too.
>
>
> Diffs
> -----
>
> src/common/http.hpp 717bbe99f2ec51a2d1b90730eb19cd54cc82b897
>
> Diff: https://reviews.apache.org/r/20403/diff/
>
>
> Testing
> -------
>
> make passed
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 20403: Add all model() declaration into
src/common/http.hpp
Posted by Chengwei Yang <ch...@gmail.com>.
> On April 17, 2014, 12:23 a.m., Dominic Hamon wrote:
> > this is used in the cpp only so there's no need for it to be added to the public header.
Yeah, I saw that, maybe make it a static function is better.
- Chengwei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20403/#review40562
-----------------------------------------------------------
On April 16, 2014, 12:35 p.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20403/
> -----------------------------------------------------------
>
> (Updated April 16, 2014, 12:35 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Add all model() declaration into src/common/http.hpp
>
> There are four overloading function model() but only three of them
> declared in src/common/http.hpp and used.
>
> In case the last one will be used in future, declare it in
> src/common/http.hpp too.
>
>
> Diffs
> -----
>
> src/common/http.hpp 717bbe99f2ec51a2d1b90730eb19cd54cc82b897
>
> Diff: https://reviews.apache.org/r/20403/diff/
>
>
> Testing
> -------
>
> make passed
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 20403: Add all model() declaration into
src/common/http.hpp
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20403/#review40562
-----------------------------------------------------------
this is used in the cpp only so there's no need for it to be added to the public header.
- Dominic Hamon
On April 15, 2014, 9:35 p.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20403/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 9:35 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Add all model() declaration into src/common/http.hpp
>
> There are four overloading function model() but only three of them
> declared in src/common/http.hpp and used.
>
> In case the last one will be used in future, declare it in
> src/common/http.hpp too.
>
>
> Diffs
> -----
>
> src/common/http.hpp 717bbe99f2ec51a2d1b90730eb19cd54cc82b897
>
> Diff: https://reviews.apache.org/r/20403/diff/
>
>
> Testing
> -------
>
> make passed
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 20403: Add all model() declaration into
src/common/http.hpp
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20403/#review40502
-----------------------------------------------------------
Patch looks great!
Reviews applied: [20403]
All tests passed.
- Mesos ReviewBot
On April 16, 2014, 4:35 a.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20403/
> -----------------------------------------------------------
>
> (Updated April 16, 2014, 4:35 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Add all model() declaration into src/common/http.hpp
>
> There are four overloading function model() but only three of them
> declared in src/common/http.hpp and used.
>
> In case the last one will be used in future, declare it in
> src/common/http.hpp too.
>
>
> Diffs
> -----
>
> src/common/http.hpp 717bbe99f2ec51a2d1b90730eb19cd54cc82b897
>
> Diff: https://reviews.apache.org/r/20403/diff/
>
>
> Testing
> -------
>
> make passed
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 20403: Make the internal use only function to be static
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20403/#review40734
-----------------------------------------------------------
Ship it!
Ship It!
- Dominic Hamon
On April 17, 2014, 7:09 p.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20403/
> -----------------------------------------------------------
>
> (Updated April 17, 2014, 7:09 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Make the internal use only function to be static
>
> Review: https://reviews.apache.org/r/20403
>
>
> Diffs
> -----
>
> src/common/http.cpp e81a7ad299652d7a969353bed883727eb4bfd794
>
> Diff: https://reviews.apache.org/r/20403/diff/
>
>
> Testing
> -------
>
> make passed
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 20403: Make the internal use only function to be static
Posted by Chengwei Yang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20403/
-----------------------------------------------------------
(Updated April 18, 2014, 10:09 a.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, and Vinod Kone.
Summary (updated)
-----------------
Make the internal use only function to be static
Repository: mesos-git
Description (updated)
-------
Make the internal use only function to be static
Review: https://reviews.apache.org/r/20403
Diffs (updated)
-----
src/common/http.cpp e81a7ad299652d7a969353bed883727eb4bfd794
Diff: https://reviews.apache.org/r/20403/diff/
Testing
-------
make passed
Thanks,
Chengwei Yang