You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Sailesh Mukil (Code Review)" <ge...@cloudera.org> on 2016/06/13 21:49:08 UTC
[Impala-CR](cdh5-2.6.0 5.8.0) xfail s3a keys do not work custom cluster test
Sailesh Mukil has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3379
Change subject: xfail s3a_keys_do_not_work custom cluster test
......................................................................
xfail s3a_keys_do_not_work custom cluster test
This test will be re-enabled in the following release as the feature
it tests is not supported in 2.6.0.
Change-Id: I4f9948fafd2f5d2363e88a60e67cf751f2fa5f93
---
M tests/custom_cluster/test_s3a_access.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/79/3379/1
--
To view, visit http://gerrit.cloudera.org:8080/3379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f9948fafd2f5d2363e88a60e67cf751f2fa5f93
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
[Impala-CR](cdh5-2.6.0 5.8.0) xfail s3a keys do not work custom cluster test
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change.
Change subject: xfail s3a_keys_do_not_work custom cluster test
......................................................................
Patch Set 2: Code-Review+2
Private build passed all tests. One test failed which is a known FE test issue: IMPALA-3526.
http://sandbox.jenkins.cloudera.com/view/Impala/view/Private-Utility/job/impala-private-build-and-test-s3/171/
--
To view, visit http://gerrit.cloudera.org:8080/3379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f9948fafd2f5d2363e88a60e67cf751f2fa5f93
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-2.6.0 5.8.0) xfail s3a keys do not work custom cluster test
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has uploaded a new patch set (#2).
Change subject: xfail s3a_keys_do_not_work custom cluster test
......................................................................
xfail s3a_keys_do_not_work custom cluster test
This test will be re-enabled in the following release as the feature
it tests is not supported in 2.6.0.
Change-Id: I4f9948fafd2f5d2363e88a60e67cf751f2fa5f93
---
M tests/custom_cluster/test_s3a_access.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/79/3379/2
--
To view, visit http://gerrit.cloudera.org:8080/3379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4f9948fafd2f5d2363e88a60e67cf751f2fa5f93
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
[Impala-CR](cdh5-2.6.0 5.8.0) xfail s3a keys do not work custom cluster test
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change.
Change subject: xfail s3a_keys_do_not_work custom cluster test
......................................................................
Patch Set 2: Code-Review+2
Approved for 5.8.0
--
To view, visit http://gerrit.cloudera.org:8080/3379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f9948fafd2f5d2363e88a60e67cf751f2fa5f93
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-2.6.0 5.8.0) xfail s3a keys do not work custom cluster test
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change.
Change subject: xfail s3a_keys_do_not_work custom cluster test
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3379/2/tests/custom_cluster/test_s3a_access.py
File tests/custom_cluster/test_s3a_access.py:
Line 68: pytest.xfail("IMPALA-3664: Feature unsupported in this branch")
So, putting this here has the equivalent effect of putting a return statement as the first line of the function -- no lines beyond this point get executed. But it seems to me like this method actually contains two distinct test cases:
- Confirm that the SELECT ... statement *fails* with bad S3 credentials
- Confirm that the CREATE ... statement *succeeds* with bad S3 credentials because it's going through the Hive metastore
Do you really want to forgo both of these test cases? Or only the test for the SELECT statement?
--
To view, visit http://gerrit.cloudera.org:8080/3379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f9948fafd2f5d2363e88a60e67cf751f2fa5f93
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-CR](cdh5-2.6.0 5.8.0) xfail s3a keys do not work custom cluster test
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change.
Change subject: xfail s3a_keys_do_not_work custom cluster test
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/3379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f9948fafd2f5d2363e88a60e67cf751f2fa5f93
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-2.6.0 5.8.0) xfail s3a keys do not work custom cluster test
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change.
Change subject: xfail s3a_keys_do_not_work custom cluster test
......................................................................
Patch Set 2:
ping? this needs to get in quick.
--
To view, visit http://gerrit.cloudera.org:8080/3379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f9948fafd2f5d2363e88a60e67cf751f2fa5f93
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-2.6.0 5.8.0) xfail s3a keys do not work custom cluster test
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change.
Change subject: xfail s3a_keys_do_not_work custom cluster test
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3379/2/tests/custom_cluster/test_s3a_access.py
File tests/custom_cluster/test_s3a_access.py:
Line 68: pytest.xfail("IMPALA-3664: Feature unsupported in this branch")
> We do not want to run this test test in the release branch because the feat
Thanks Sailesh for the explanation. I guess I was just wondering, would it work to move the xfail() call to just before the last line of the method here? Because from looking at the JIRA, it appears like the the CREATE query succeeds -- it's just the SELECT query that fails. (In my mind, those are really seem to be two separate tests, since they undoubtedly exercise two vary different code paths.)
In other words, would it be worthwhile to continue confirming that the CREATE query continues to perform as expected, even when bad S3 credentials are supplied? Or do you want to bypass both tests?
--
To view, visit http://gerrit.cloudera.org:8080/3379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f9948fafd2f5d2363e88a60e67cf751f2fa5f93
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-CR](cdh5-2.6.0 5.8.0) xfail s3a keys do not work custom cluster test
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change.
Change subject: xfail s3a_keys_do_not_work custom cluster test
......................................................................
Patch Set 2: Code-Review+2
Sailesh explained further the rationale in an offline discussion. This change looks good to me.
--
To view, visit http://gerrit.cloudera.org:8080/3379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f9948fafd2f5d2363e88a60e67cf751f2fa5f93
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-2.6.0 5.8.0) xfail s3a keys do not work custom cluster test
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change.
Change subject: xfail s3a_keys_do_not_work custom cluster test
......................................................................
Patch Set 2:
(1 comment)
Thanks for looking at this David.
http://gerrit.cloudera.org:8080/#/c/3379/2/tests/custom_cluster/test_s3a_access.py
File tests/custom_cluster/test_s3a_access.py:
Line 68: pytest.xfail("IMPALA-3664: Feature unsupported in this branch")
> So, putting this here has the equivalent effect of putting a return stateme
We do not want to run this test test in the release branch because the feature that it tests (secure management of S3 keys) does not work in this particular branch. We have a fix for that feature but the fix will go into trunk instead, and this test will be reenabled along with the fix.
--
To view, visit http://gerrit.cloudera.org:8080/3379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f9948fafd2f5d2363e88a60e67cf751f2fa5f93
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-CR](cdh5-2.6.0 5.8.0) xfail s3a keys do not work custom cluster test
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has submitted this change and it was merged.
Change subject: xfail s3a_keys_do_not_work custom cluster test
......................................................................
xfail s3a_keys_do_not_work custom cluster test
This test will be re-enabled in the following release as the feature
it tests is not supported in 2.6.0.
Change-Id: I4f9948fafd2f5d2363e88a60e67cf751f2fa5f93
Reviewed-on: http://gerrit.cloudera.org:8080/3379
Reviewed-by: David Knupp <dk...@cloudera.com>
Reviewed-by: Dan Hecht <dh...@cloudera.com>
Reviewed-by: Sailesh Mukil <sa...@cloudera.com>
Tested-by: Sailesh Mukil <sa...@cloudera.com>
---
M tests/custom_cluster/test_s3a_access.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
David Knupp: Looks good to me, approved
Sailesh Mukil: Looks good to me, approved; Verified
Dan Hecht: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/3379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f9948fafd2f5d2363e88a60e67cf751f2fa5f93
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>