You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/09/02 15:56:42 UTC

[GitHub] [shardingsphere] sandynz opened a new pull request #7231: Fix #7207 : INSERT...RETURING statement failed in PostgreSQL DML integration test

sandynz opened a new pull request #7231:
URL: https://github.com/apache/shardingsphere/pull/7231


   Fixes #7207 .
   
   Changes proposed in this pull request:
   - Compatible with INSERT...RETURNING IT
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tuohai666 merged pull request #7231: Fix #7207 : INSERT...RETURING statement failed in PostgreSQL DML integration test

Posted by GitBox <gi...@apache.org>.
tuohai666 merged pull request #7231:
URL: https://github.com/apache/shardingsphere/pull/7231


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] coveralls commented on pull request #7231: Fix #7207 : INSERT...RETURING statement failed in PostgreSQL DML integration test

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #7231:
URL: https://github.com/apache/shardingsphere/pull/7231#issuecomment-685859168


   ## Pull Request Test Coverage Report for [Build 14382](https://coveralls.io/builds/33182451)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage remained the same at **35.602%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/33182451/badge)](https://coveralls.io/builds/33182451) |
   | :-- | --: |
   | Change from base [Build 14377](https://coveralls.io/builds/33173208): |  0.0% |
   | Covered Lines: | 35622 |
   | Relevant Lines: | 100055 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] sandynz commented on pull request #7231: Fix #7207 : INSERT...RETURING statement failed in PostgreSQL DML integration test

Posted by GitBox <gi...@apache.org>.
sandynz commented on pull request #7231:
URL: https://github.com/apache/shardingsphere/pull/7231#issuecomment-685833119


   When `preparedStatement.execute()` and `statement.execute(getSql())` return true, `statement.getResultSet()` return null, it might be a ShardingSphere issue.
   When testing with native jdbc, PostgreSQL will return not null `ResultSet`, though `getMoreResults()` return false.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org