You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by pgandhi999 <gi...@git.apache.org> on 2018/12/01 07:22:33 UTC
[GitHub] spark pull request #23160: [SPARK-26196][WebUI] Total tasks title in the sta...
Github user pgandhi999 commented on a diff in the pull request:
https://github.com/apache/spark/pull/23160#discussion_r238055402
--- Diff: core/src/main/resources/org/apache/spark/ui/static/stagepage.js ---
@@ -661,8 +662,8 @@ $(document).ready(function () {
{data : "launchTime", name: "Launch Time", render: formatDate},
{
data : function (row, type) {
- if (row.duration) {
- return type === 'display' ? formatDuration(row.duration) : row.duration;
+ if (row.taskMetrics && row.taskMetrics.executorRunTime) {
+ return type === 'display' ? formatDuration(row.taskMetrics.executorRunTime) : row.taskMetrics.executorRunTime;
--- End diff --
Ok, that makes sense. However, you also need to update the search filter method to not search on duration in StagesResource.scala here:
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/status/api/v1/StagesResource.scala#L213.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org