You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Lucas Nelson (JIRA)" <ji...@apache.org> on 2008/11/17 23:48:37 UTC

[jira] Created: (WW-2874) Dispatcher logs an error / severe from serviceAction() before it returns a 404 "Could not find action or result"

Dispatcher logs an error / severe from serviceAction() before it returns a 404 "Could not find action or result"
----------------------------------------------------------------------------------------------------------------

                 Key: WW-2874
                 URL: https://issues.apache.org/struts/browse/WW-2874
             Project: Struts 2
          Issue Type: Bug
    Affects Versions: 2.1.2
         Environment: Tomcat 6.0.18, Struts 2.1.2
            Reporter: Lucas Nelson


We are getting severe logs from org.apache.struts2.dispatcher.Dispatcher.serviceAction() (line 485) when broken spiders hit our site with all-lowercase URLs. Our actions are named with the usual camel-hump style naming, so the server is returning a 404 to the client. This is all good.

But, just before it returns the 404, the Dispatcher logs at error level: "Could not find action or result".

We are trying to get to the situation where we can have all severe / error logs trigger an alert to wake someone up in the middle of the night to go look at the system. Having client-initiated activity triggering logging at severe / error level does not seem right.

Any chance this log at line 485 could be lowered to a warning, at least?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (WW-2874) Dispatcher logs an error / severe from serviceAction() before it returns a 404 "Could not find action or result"

Posted by "Wes Wannemacher (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45243#action_45243 ] 

Wes Wannemacher commented on WW-2874:
-------------------------------------

I think maybe a good idea would be to log an error if/when using devMode, but a warn otherwise. In production, you don't have much control over 404s, but since struts2 makes use of explicit mappings, it's good to know about 404s when in development... Of course, a warning is still sufficient, so having it behave different in devMode might be overkill.

> Dispatcher logs an error / severe from serviceAction() before it returns a 404 "Could not find action or result"
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: WW-2874
>                 URL: https://issues.apache.org/struts/browse/WW-2874
>             Project: Struts 2
>          Issue Type: Improvement
>    Affects Versions: 2.1.2
>         Environment: Tomcat 6.0.18, Struts 2.1.2
>            Reporter: Lucas Nelson
>             Fix For: 2.1.3
>
>
> We are getting severe logs from org.apache.struts2.dispatcher.Dispatcher.serviceAction() (line 485) when broken spiders hit our site with all-lowercase URLs. Our actions are named with the usual camel-hump style naming, so the server is returning a 404 to the client. This is all good.
> But, just before it returns the 404, the Dispatcher logs at error level: "Could not find action or result".
> We are trying to get to the situation where we can have all severe / error logs trigger an alert to wake someone up in the middle of the night to go look at the system. Having client-initiated activity triggering logging at severe / error level does not seem right.
> Any chance this log at line 485 could be lowered to a warning, at least?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WW-2874) Dispatcher logs an error / severe from serviceAction() before it returns a 404 "Could not find action or result"

Posted by "James Holmes (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Holmes updated WW-2874:
-----------------------------

    Fix Version/s: 2.1.3
       Issue Type: Improvement  (was: Bug)

Any thoughts from anyone on this? I think it makes sense to make it a warning.

> Dispatcher logs an error / severe from serviceAction() before it returns a 404 "Could not find action or result"
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: WW-2874
>                 URL: https://issues.apache.org/struts/browse/WW-2874
>             Project: Struts 2
>          Issue Type: Improvement
>    Affects Versions: 2.1.2
>         Environment: Tomcat 6.0.18, Struts 2.1.2
>            Reporter: Lucas Nelson
>             Fix For: 2.1.3
>
>
> We are getting severe logs from org.apache.struts2.dispatcher.Dispatcher.serviceAction() (line 485) when broken spiders hit our site with all-lowercase URLs. Our actions are named with the usual camel-hump style naming, so the server is returning a 404 to the client. This is all good.
> But, just before it returns the 404, the Dispatcher logs at error level: "Could not find action or result".
> We are trying to get to the situation where we can have all severe / error logs trigger an alert to wake someone up in the middle of the night to go look at the system. Having client-initiated activity triggering logging at severe / error level does not seem right.
> Any chance this log at line 485 could be lowered to a warning, at least?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (WW-2874) Dispatcher logs an error / severe from serviceAction() before it returns a 404 "Could not find action or result"

Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45244#action_45244 ] 

Musachy Barroso commented on WW-2874:
-------------------------------------

+1 for Wes' idea (error if devMode, warning otherwise)

> Dispatcher logs an error / severe from serviceAction() before it returns a 404 "Could not find action or result"
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: WW-2874
>                 URL: https://issues.apache.org/struts/browse/WW-2874
>             Project: Struts 2
>          Issue Type: Improvement
>    Affects Versions: 2.1.2
>         Environment: Tomcat 6.0.18, Struts 2.1.2
>            Reporter: Lucas Nelson
>             Fix For: 2.1.3
>
>
> We are getting severe logs from org.apache.struts2.dispatcher.Dispatcher.serviceAction() (line 485) when broken spiders hit our site with all-lowercase URLs. Our actions are named with the usual camel-hump style naming, so the server is returning a 404 to the client. This is all good.
> But, just before it returns the 404, the Dispatcher logs at error level: "Could not find action or result".
> We are trying to get to the situation where we can have all severe / error logs trigger an alert to wake someone up in the middle of the night to go look at the system. Having client-initiated activity triggering logging at severe / error level does not seem right.
> Any chance this log at line 485 could be lowered to a warning, at least?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (WW-2874) Dispatcher logs an error / severe from serviceAction() before it returns a 404 "Could not find action or result"

Posted by "Nils-Helge Garli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nils-Helge Garli resolved WW-2874.
----------------------------------

    Resolution: Fixed

Proposed fix committed.

> Dispatcher logs an error / severe from serviceAction() before it returns a 404 "Could not find action or result"
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: WW-2874
>                 URL: https://issues.apache.org/struts/browse/WW-2874
>             Project: Struts 2
>          Issue Type: Improvement
>    Affects Versions: 2.1.2
>         Environment: Tomcat 6.0.18, Struts 2.1.2
>            Reporter: Lucas Nelson
>            Assignee: Nils-Helge Garli
>             Fix For: 2.1.3
>
>
> We are getting severe logs from org.apache.struts2.dispatcher.Dispatcher.serviceAction() (line 485) when broken spiders hit our site with all-lowercase URLs. Our actions are named with the usual camel-hump style naming, so the server is returning a 404 to the client. This is all good.
> But, just before it returns the 404, the Dispatcher logs at error level: "Could not find action or result".
> We are trying to get to the situation where we can have all severe / error logs trigger an alert to wake someone up in the middle of the night to go look at the system. Having client-initiated activity triggering logging at severe / error level does not seem right.
> Any chance this log at line 485 could be lowered to a warning, at least?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (WW-2874) Dispatcher logs an error / severe from serviceAction() before it returns a 404 "Could not find action or result"

Posted by "Nils-Helge Garli (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45357#action_45357 ] 

Nils-Helge Garli commented on WW-2874:
--------------------------------------

+1 

I'll commit a fix if everyone is ok with it?

> Dispatcher logs an error / severe from serviceAction() before it returns a 404 "Could not find action or result"
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: WW-2874
>                 URL: https://issues.apache.org/struts/browse/WW-2874
>             Project: Struts 2
>          Issue Type: Improvement
>    Affects Versions: 2.1.2
>         Environment: Tomcat 6.0.18, Struts 2.1.2
>            Reporter: Lucas Nelson
>            Assignee: Nils-Helge Garli
>             Fix For: 2.1.3
>
>
> We are getting severe logs from org.apache.struts2.dispatcher.Dispatcher.serviceAction() (line 485) when broken spiders hit our site with all-lowercase URLs. Our actions are named with the usual camel-hump style naming, so the server is returning a 404 to the client. This is all good.
> But, just before it returns the 404, the Dispatcher logs at error level: "Could not find action or result".
> We are trying to get to the situation where we can have all severe / error logs trigger an alert to wake someone up in the middle of the night to go look at the system. Having client-initiated activity triggering logging at severe / error level does not seem right.
> Any chance this log at line 485 could be lowered to a warning, at least?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (WW-2874) Dispatcher logs an error / severe from serviceAction() before it returns a 404 "Could not find action or result"

Posted by "Wes Wannemacher (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45359#action_45359 ] 

Wes Wannemacher commented on WW-2874:
-------------------------------------

Nils,

I've been meaning to commit this, it's rather trivial to implement what I intended, I just haven't had a chance. Go ahead if you'd like.

> Dispatcher logs an error / severe from serviceAction() before it returns a 404 "Could not find action or result"
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: WW-2874
>                 URL: https://issues.apache.org/struts/browse/WW-2874
>             Project: Struts 2
>          Issue Type: Improvement
>    Affects Versions: 2.1.2
>         Environment: Tomcat 6.0.18, Struts 2.1.2
>            Reporter: Lucas Nelson
>            Assignee: Nils-Helge Garli
>             Fix For: 2.1.3
>
>
> We are getting severe logs from org.apache.struts2.dispatcher.Dispatcher.serviceAction() (line 485) when broken spiders hit our site with all-lowercase URLs. Our actions are named with the usual camel-hump style naming, so the server is returning a 404 to the client. This is all good.
> But, just before it returns the 404, the Dispatcher logs at error level: "Could not find action or result".
> We are trying to get to the situation where we can have all severe / error logs trigger an alert to wake someone up in the middle of the night to go look at the system. Having client-initiated activity triggering logging at severe / error level does not seem right.
> Any chance this log at line 485 could be lowered to a warning, at least?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Assigned: (WW-2874) Dispatcher logs an error / severe from serviceAction() before it returns a 404 "Could not find action or result"

Posted by "Nils-Helge Garli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nils-Helge Garli reassigned WW-2874:
------------------------------------

    Assignee: Nils-Helge Garli

> Dispatcher logs an error / severe from serviceAction() before it returns a 404 "Could not find action or result"
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: WW-2874
>                 URL: https://issues.apache.org/struts/browse/WW-2874
>             Project: Struts 2
>          Issue Type: Improvement
>    Affects Versions: 2.1.2
>         Environment: Tomcat 6.0.18, Struts 2.1.2
>            Reporter: Lucas Nelson
>            Assignee: Nils-Helge Garli
>             Fix For: 2.1.3
>
>
> We are getting severe logs from org.apache.struts2.dispatcher.Dispatcher.serviceAction() (line 485) when broken spiders hit our site with all-lowercase URLs. Our actions are named with the usual camel-hump style naming, so the server is returning a 404 to the client. This is all good.
> But, just before it returns the 404, the Dispatcher logs at error level: "Could not find action or result".
> We are trying to get to the situation where we can have all severe / error logs trigger an alert to wake someone up in the middle of the night to go look at the system. Having client-initiated activity triggering logging at severe / error level does not seem right.
> Any chance this log at line 485 could be lowered to a warning, at least?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (WW-2874) Dispatcher logs an error / severe from serviceAction() before it returns a 404 "Could not find action or result"

Posted by "James Holmes (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45245#action_45245 ] 

James Holmes commented on WW-2874:
----------------------------------

Ok, Wes' idea works for me too.

> Dispatcher logs an error / severe from serviceAction() before it returns a 404 "Could not find action or result"
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: WW-2874
>                 URL: https://issues.apache.org/struts/browse/WW-2874
>             Project: Struts 2
>          Issue Type: Improvement
>    Affects Versions: 2.1.2
>         Environment: Tomcat 6.0.18, Struts 2.1.2
>            Reporter: Lucas Nelson
>             Fix For: 2.1.3
>
>
> We are getting severe logs from org.apache.struts2.dispatcher.Dispatcher.serviceAction() (line 485) when broken spiders hit our site with all-lowercase URLs. Our actions are named with the usual camel-hump style naming, so the server is returning a 404 to the client. This is all good.
> But, just before it returns the 404, the Dispatcher logs at error level: "Could not find action or result".
> We are trying to get to the situation where we can have all severe / error logs trigger an alert to wake someone up in the middle of the night to go look at the system. Having client-initiated activity triggering logging at severe / error level does not seem right.
> Any chance this log at line 485 could be lowered to a warning, at least?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.