[jira] [Commented] (PHOENIX-6064) Make Tephra support optional

["Hadoop QA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-6064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17174414#comment-17174414 ] 

Hadoop QA commented on PHOENIX-6064:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/13009380/PHOENIX-6064.master.v1.patch
  against master branch at commit ffeddf55328ac69dac6ee565abec34e1f7002d13.
  ATTACHMENT ID: 13009380

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 0 new or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings (more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +                for (TransactionFactory.Provider aprovider : TransactionFactory.Provider.available()) {
+    private static final NotAvailableTransactionProvider INSTANCE = new NotAvailableTransactionProvider();
+    public PhoenixTransactionContext getTransactionContext(PhoenixConnection connection) throws SQLException {
+    public PhoenixTransactionClient getTransactionClient(Configuration config, ConnectionInfo connectionInfo) {
+    public PhoenixTransactionService getTransactionService(Configuration config, ConnectionInfo connInfo, int port) {

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/4090//testReport/
Code Coverage results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/4090//artifact/phoenix-core/target/site/jacoco/index.html
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/4090//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/4090//console

This message is automatically generated.

> Make Tephra support optional
> ----------------------------
>
>                 Key: PHOENIX-6064
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6064
>             Project: Phoenix
>          Issue Type: Improvement
>          Components: core, tephra
>    Affects Versions: 5.1.0
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Major
>         Attachments: PHOENIX-6064.master.v1.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Tephra has and old Guava dependency, that cannot be removed due to Twill depending on it. Removing the Twill dependency from Tephra is possible, but not trivial. 
> This Guava has CVEs, which will show up in static analysis tools, which will cause some potential users not to adopt Phoenix.
> Provide an option to build Phoenix without Tephra, and its problematic dependencies.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)