You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/09/12 00:06:51 UTC

[GitHub] [orc] dongjoon-hyun commented on a change in pull request #905: ORC-991: Fix the bug of encrypted column read crash

dongjoon-hyun commented on a change in pull request #905:
URL: https://github.com/apache/orc/pull/905#discussion_r706709957



##########
File path: java/core/src/java/org/apache/orc/impl/reader/StripePlanner.java
##########
@@ -279,12 +280,13 @@ private void buildEncodings(OrcProto.StripeFooter footer,
   private long handleStream(long offset,
                             boolean[] columnInclude,
                             OrcProto.Stream stream,
+                            StreamName.Area area,

Review comment:
       Could you add `area` into the function description, too?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org