You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "biyuhao (GitHub)" <gi...@apache.org> on 2019/01/02 14:14:46 UTC

[GitHub] [incubator-dubbo-ops] biyuhao opened pull request #226: Optimize logging

using logging framework instead of `e.printStack()` to console

About logging, I noticed that there are very few logs in our controller/service.
I think it's better to add some trace log.

[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/226 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #226: Optimize logging

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/226?src=pr&el=h1) Report
> Merging [#226](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/226?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/c8bc1de3c5baf01bdd5bb0b5578de5f1d995e789?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/226/graphs/tree.svg?width=650&token=fYsc8RuDGB&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/226?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             develop    #226      +/-   ##
============================================
- Coverage       0.57%   0.57%   -0.01%     
  Complexity         7       7              
============================================
  Files             82      82              
  Lines           3280    3284       +4     
  Branches         521     521              
============================================
  Hits              19      19              
- Misses          3260    3264       +4     
  Partials           1       1
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/226?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...admin/data/config/impl/ZookeeperConfiguration.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/226/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vZGF0YS9jb25maWcvaW1wbC9ab29rZWVwZXJDb25maWd1cmF0aW9uLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...data/metadata/impl/ZookeeperMetaDataCollector.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/226/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vZGF0YS9tZXRhZGF0YS9pbXBsL1pvb2tlZXBlck1ldGFEYXRhQ29sbGVjdG9yLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/dubbo/admin/common/util/MD5Util.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/226/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29tbW9uL3V0aWwvTUQ1VXRpbC5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/226?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/226?src=pr&el=footer). Last update [c8bc1de...76d0862](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/226?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/226 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #226: Optimize logging

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/226?src=pr&el=h1) Report
> Merging [#226](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/226?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/c8bc1de3c5baf01bdd5bb0b5578de5f1d995e789?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/226/graphs/tree.svg?width=650&token=fYsc8RuDGB&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/226?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             develop    #226      +/-   ##
============================================
- Coverage       0.57%   0.57%   -0.01%     
  Complexity         7       7              
============================================
  Files             82      82              
  Lines           3280    3284       +4     
  Branches         521     521              
============================================
  Hits              19      19              
- Misses          3260    3264       +4     
  Partials           1       1
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/226?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...admin/data/config/impl/ZookeeperConfiguration.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/226/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vZGF0YS9jb25maWcvaW1wbC9ab29rZWVwZXJDb25maWd1cmF0aW9uLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...data/metadata/impl/ZookeeperMetaDataCollector.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/226/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vZGF0YS9tZXRhZGF0YS9pbXBsL1pvb2tlZXBlck1ldGFEYXRhQ29sbGVjdG9yLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/dubbo/admin/common/util/MD5Util.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/226/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29tbW9uL3V0aWwvTUQ1VXRpbC5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/226?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/226?src=pr&el=footer). Last update [c8bc1de...76d0862](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/226?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/226 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] nzomkxia commented on issue #226: Optimize logging

Posted by "nzomkxia (GitHub)" <gi...@apache.org>.
Thank you for your pr, I'll merge it

[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/226 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] nzomkxia closed pull request #226: Optimize logging

Posted by "nzomkxia (GitHub)" <gi...@apache.org>.
[ pull request closed by nzomkxia ]

[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/226 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org