You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "amoghrajesh (via GitHub)" <gi...@apache.org> on 2025/10/27 10:46:30 UTC
[PR] Log execution API server URL at task startup [airflow]
amoghrajesh opened a new pull request, #57343:
URL: https://github.com/apache/airflow/pull/57343
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
There could be cases when custom executors (edge for example faced it), where we do not log where the worker is trying to connect during task startup time.
Edge: https://github.com/apache/airflow/blob/main/providers/edge3/src/airflow/providers/edge3/cli/worker.py#L188-L204
VS celery / KE: https://github.com/apache/airflow/blob/main/task-sdk/src/airflow/sdk/execution_time/execute_workload.py#L58-L64
I figured it is better to have double logs for debugging than none. I could remove it for celery / KE and rest if needed, but this one is more important.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Log execution API server URL at task startup [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #57343:
URL: https://github.com/apache/airflow/pull/57343#discussion_r2465216017
##########
task-sdk/src/airflow/sdk/execution_time/supervisor.py:
##########
@@ -1930,6 +1930,7 @@ def supervise(
limits = httpx.Limits(max_keepalive_connections=1, max_connections=10)
client = Client(base_url=server or "", limits=limits, dry_run=dry_run, token=token)
close_client = True
+ log.info("Connecting to execution API server", server=server)
Review Comment:
Better as debug log then?
```suggestion
log.debug("Connecting to execution API server", server=server)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Log execution API server URL at task startup [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh merged PR #57343:
URL: https://github.com/apache/airflow/pull/57343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Log execution API server URL at task startup [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #57343:
URL: https://github.com/apache/airflow/pull/57343#discussion_r2465219219
##########
task-sdk/src/airflow/sdk/execution_time/supervisor.py:
##########
@@ -1930,6 +1930,7 @@ def supervise(
limits = httpx.Limits(max_keepalive_connections=1, max_connections=10)
client = Client(base_url=server or "", limits=limits, dry_run=dry_run, token=token)
close_client = True
+ log.info("Connecting to execution API server", server=server)
Review Comment:
Thought I changed it before pushing, yeah thats better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Log execution API server URL at task startup [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57343:
URL: https://github.com/apache/airflow/pull/57343#issuecomment-3454933852
### Backport successfully created: v3-1-test
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>✅</td>
<td>v3-1-test</td>
<td><a href="https://github.com/apache/airflow/pull/57409"><img src="https://img.shields.io/badge/PR-57409-blue" alt="PR Link"></a></td>
</tr>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Log execution API server URL at task startup [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #57343:
URL: https://github.com/apache/airflow/pull/57343#issuecomment-3454927932
> Good for me. The title anticipated "Move" but I see "Add - is the log to be deleted on some other place?
Nope, no deletions anywhere. I could delete in "execute_workload.py" to avoid duplicates, will send a PR to do that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org