You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/09/11 04:36:17 UTC
[GitHub] [lucene-solr] PuneethBikkumanla opened a new pull request #1858: LUCENE-6744: initial fix to few files untested
PuneethBikkumanla opened a new pull request #1858:
URL: https://github.com/apache/lucene-solr/pull/1858
# Description
Hey everyone! This is my first PR.
In this PR, I am addressing the concern of the original ticket that the equals method is asymmetrically comparing two objects. I currently changed some of the files requested in the ticket but will go ahead and change the rest once I know I'm on the right path.
Also, am currently figuring out how/where to add documentation changes to the Ref Guide regarding this PR.
# Solution
Instead of using `instanceOf` I used `getClass` in the `equals` method as described in the original Jira ticket
# Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
Currently I have not added any tests to verify this change as the existing tests that I found for these classes do not make it easy to test this. I just wanted to open up a PR to check whether I'm on the right track and for some help on figuring out where/how I could test these changes.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `master` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] PuneethBikkumanla edited a comment on pull request #1858: LUCENE-6744: equals methods should compare classes directly, not use instanceof
Posted by GitBox <gi...@apache.org>.
PuneethBikkumanla edited a comment on pull request #1858:
URL: https://github.com/apache/lucene-solr/pull/1858#issuecomment-692813025
> Are there any tests that can be added to show how instanceOf fails or inferior?
I will add tests testing this. I actually traced through the code currently testing these classes, but there didn't seem to be any tests testing them individually. I'll look into how I can add tests into the existing framework or add new tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] PuneethBikkumanla commented on pull request #1858: LUCENE-6744: equals methods should compare classes directly, not use instanceof
Posted by GitBox <gi...@apache.org>.
PuneethBikkumanla commented on pull request #1858:
URL: https://github.com/apache/lucene-solr/pull/1858#issuecomment-692813025
> Are there any tests that can be added to show how instanceOf fails or inferior?
I will look to add tests. I actually traced through the code currently testing these classes, but there didn't seem to be any tests testing them individually. I'll look into how I can add tests into the existing framework or add new test classes to test this behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org