You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/04/20 09:23:03 UTC

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #3094: ARTEMIS-2717 Isolate the current Quorum Vote implementation

franz1981 commented on a change in pull request #3094:
URL: https://github.com/apache/activemq-artemis/pull/3094#discussion_r411226674



##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/ClusterControl.java
##########
@@ -64,6 +62,10 @@ public ClusterControl(ClientSessionFactoryInternal sessionFactory, ActiveMQServe
       this.clusterPassword = server.getConfiguration().getClusterPassword();
    }
 
+   public Optional<Channel> getClusterChannel() {

Review comment:
       @michaelandrepearce @brusdev Not proud to have "exposed" the lower level `Channel` here, but it seems the simplest way to move away he many  `Quorum*` deps away from here




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org