You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/19 07:25:49 UTC

[GitHub] [arrow] seddonm1 commented on a change in pull request #8966: ARROW-10969: [Rust][DataFusion] Implement basic String ANSI SQL Functions

seddonm1 commented on a change in pull request #8966:
URL: https://github.com/apache/arrow/pull/8966#discussion_r546205335



##########
File path: rust/datafusion/src/physical_plan/functions.rs
##########
@@ -118,6 +118,14 @@ pub enum BuiltinScalarFunction {
     Length,
     /// concat
     Concat,
+    /// character_length
+    CharacterLength,
+    /// lower
+    Lower,
+    /// upper
+    Upper,
+    /// ltrim

Review comment:
       Yes, sorry, I had actually implemented quite a few more functions (more `ltrim`, `rtrim` and `position`) but then removed them as technically `ltrim` and `rtrim` is not part of the ANSI standard but are Postgres additions (and others).
   
   I think the decision on SQL dialect to support is required before continuing too much further.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org