You are viewing a plain text version of this content. The canonical link for it is here.

Posted to surefire-dev@maven.apache.org by Brett Porter <br...@apache.org> on 2007/06/04 13:59:07 UTC

Re: svn commit: r544132 - in /maven/surefire/trunk: maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/ surefire-booter/src/main/java/org/apache/maven/surefire/booter/

Hi Kenney,

On 04/06/2007, at 9:51 PM, kenney@apache.org wrote:

> -        surefireArtifact.isSnapshot(); // TODO: this is  
> ridiculous, but it fixes getBaseVersion to be -SNAPSHOT if needed
> +        //surefireArtifact.isSnapshot(); // TODO: this is  
> ridiculous, but it fixes getBaseVersion to be -SNAPSHOT if needed

What was the reason to comment this out?

- Brett

Re: svn commit: r544132 - in /maven/surefire/trunk: maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/ surefire-booter/src/main/java/org/apache/maven/surefire/booter/

Posted by Kenney Westerhof <ke...@apache.org>.

Brett Porter wrote:
> Hi Kenney,
> 
> On 04/06/2007, at 9:51 PM, kenney@apache.org wrote:
> 
>> -        surefireArtifact.isSnapshot(); // TODO: this is ridiculous, 
>> but it fixes getBaseVersion to be -SNAPSHOT if needed
>> +        //surefireArtifact.isSnapshot(); // TODO: this is ridiculous, 
>> but it fixes getBaseVersion to be -SNAPSHOT if needed
> 
> What was the reason to comment this out?

My bad, it was still in my local changeset when I was working on fixing that TODO (months ago); I accidently
committed it. 

Thanks for noticing ;) I was just trying to figure out why the surefire plugin
couldn't find surefire-junit4... Serves me right for not svn diffing this time before committing! :)

It's reverted in svn and I redeployed the plugin.

Thanks!

	Kenney

> 
> - Brett