You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Eric DE MAULDE (JIRA)" <ji...@apache.org> on 2009/03/04 16:31:56 UTC
[jira] Created: (OFBIZ-2228) When a virtual product is modified,
its variants aren't modified
When a virtual product is modified, its variants aren't modified
----------------------------------------------------------------
Key: OFBIZ-2228
URL: https://issues.apache.org/jira/browse/OFBIZ-2228
Project: OFBiz
Issue Type: New Feature
Components: framework, product
Affects Versions: SVN trunk
Environment: trunk revision 748987
Reporter: Eric DE MAULDE
Priority: Trivial
Fix For: SVN trunk
I would like modify product Variants from its Virtual Product
By example, to :
- add (update / delete) category
- add (update / delete) price
- add (update / delete) config
- add (update / delete) supplier
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2228) When a virtual product is modified,
its variants aren't modified
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680769#action_12680769 ]
Jacques Le Roux commented on OFBIZ-2228:
----------------------------------------
Hi Eric,
Thanks for feedback, OK I will... I think it's an interesting feature...
> When a virtual product is modified, its variants aren't modified
> ----------------------------------------------------------------
>
> Key: OFBIZ-2228
> URL: https://issues.apache.org/jira/browse/OFBIZ-2228
> Project: OFBiz
> Issue Type: New Feature
> Components: framework, product
> Affects Versions: SVN trunk
> Environment: trunk revision 748987
> Reporter: Eric DE MAULDE
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: ServiceVariant_from-virtual.patch
>
>
> I would like modify product Variants from its Virtual Product
> By example, to :
> - add (update / delete) category
> - add (update / delete) price
> - add (update / delete) config
> - add (update / delete) supplier
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2228) When a virtual product is modified,
its variants aren't modified
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682249#action_12682249 ]
Jacques Le Roux commented on OFBIZ-2228:
----------------------------------------
Yes, you are right Vince. Also It's a long time now since [this thread|http://markmail.org/message/plgg6mzsx6xxacv4] and I did not check if it's working right. Could someone check it please ?
> When a virtual product is modified, its variants aren't modified
> ----------------------------------------------------------------
>
> Key: OFBIZ-2228
> URL: https://issues.apache.org/jira/browse/OFBIZ-2228
> Project: OFBiz
> Issue Type: New Feature
> Components: framework, product
> Affects Versions: SVN trunk
> Environment: trunk revision 748987
> Reporter: Eric DE MAULDE
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: ServiceVariant_from-virtual.patch
>
>
> I would like modify product Variants from its Virtual Product
> By example, to :
> - add (update / delete) category
> - add (update / delete) price
> - add (update / delete) config
> - add (update / delete) supplier
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2228) When a virtual product is modified,
its variants aren't modified
Posted by "Eric DE MAULDE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric DE MAULDE updated OFBIZ-2228:
----------------------------------
Attachment: ServiceVariant_from-virtual.patch
This patch allows to modify each Product VARIANT from its VIRTUAL Products
Product Controller calls the new file : ServiceVariantEventHandler.java
I configured the following services :
- addProductToCategory (update / delete)
- createProductConfig ( update / delete)
- createProductPrice (update / delete)
- createSuplierProduct (update / delete)
> When a virtual product is modified, its variants aren't modified
> ----------------------------------------------------------------
>
> Key: OFBIZ-2228
> URL: https://issues.apache.org/jira/browse/OFBIZ-2228
> Project: OFBiz
> Issue Type: New Feature
> Components: framework, product
> Affects Versions: SVN trunk
> Environment: trunk revision 748987
> Reporter: Eric DE MAULDE
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: ServiceVariant_from-virtual.patch
>
>
> I would like modify product Variants from its Virtual Product
> By example, to :
> - add (update / delete) category
> - add (update / delete) price
> - add (update / delete) config
> - add (update / delete) supplier
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2228) When a virtual product is modified,
its variants aren't modified
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679692#action_12679692 ]
Jacques Le Roux commented on OFBIZ-2228:
----------------------------------------
BTW I just discovered the XXX annotation in comment for "something that is bogus but works" (in conjuction with TODO). Not much used in OFBiz...
> When a virtual product is modified, its variants aren't modified
> ----------------------------------------------------------------
>
> Key: OFBIZ-2228
> URL: https://issues.apache.org/jira/browse/OFBIZ-2228
> Project: OFBiz
> Issue Type: New Feature
> Components: framework, product
> Affects Versions: SVN trunk
> Environment: trunk revision 748987
> Reporter: Eric DE MAULDE
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: ServiceVariant_from-virtual.patch
>
>
> I would like modify product Variants from its Virtual Product
> By example, to :
> - add (update / delete) category
> - add (update / delete) price
> - add (update / delete) config
> - add (update / delete) supplier
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2228) When a virtual product is modified,
its variants aren't modified
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680449#action_12680449 ]
Jacques Le Roux commented on OFBIZ-2228:
----------------------------------------
Hi Eric,
I just would like to know if you expect to create a ServiceVariantsEventHandler.java out of the framework ?
Thanks
> When a virtual product is modified, its variants aren't modified
> ----------------------------------------------------------------
>
> Key: OFBIZ-2228
> URL: https://issues.apache.org/jira/browse/OFBIZ-2228
> Project: OFBiz
> Issue Type: New Feature
> Components: framework, product
> Affects Versions: SVN trunk
> Environment: trunk revision 748987
> Reporter: Eric DE MAULDE
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: ServiceVariant_from-virtual.patch
>
>
> I would like modify product Variants from its Virtual Product
> By example, to :
> - add (update / delete) category
> - add (update / delete) price
> - add (update / delete) config
> - add (update / delete) supplier
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2228) When a virtual product is modified,
its variants aren't modified
Posted by "Eric DE MAULDE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680730#action_12680730 ]
Eric DE MAULDE commented on OFBIZ-2228:
---------------------------------------
Hi Jacques,
Sorry for my delay. This week I don't have time to modify my patch.
I havn't still use "custom event handler"
I think you're more efficiant than me to implement this functionality
> When a virtual product is modified, its variants aren't modified
> ----------------------------------------------------------------
>
> Key: OFBIZ-2228
> URL: https://issues.apache.org/jira/browse/OFBIZ-2228
> Project: OFBiz
> Issue Type: New Feature
> Components: framework, product
> Affects Versions: SVN trunk
> Environment: trunk revision 748987
> Reporter: Eric DE MAULDE
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: ServiceVariant_from-virtual.patch
>
>
> I would like modify product Variants from its Virtual Product
> By example, to :
> - add (update / delete) category
> - add (update / delete) price
> - add (update / delete) config
> - add (update / delete) supplier
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2228) When a virtual product is modified,
its variants aren't modified
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679691#action_12679691 ]
Jacques Le Roux commented on OFBIZ-2228:
----------------------------------------
Sorry Eric,
I did not occur to me (I focused on the code and forgot the architecture level) but David whatch over : this patch introduces a dependency from product component into the framework. So I reverted in r751001 at David's demand.
I suggest that you create a custom event handler in the product component and not in framework. Something like
<handler name="simplecontent" type="view" class="org.ofbiz.content.view.SimpleContentViewHandler"/>
would be appropriate
Also please have a look at changes done by Adam in r749339 and r749341 and the ones I did after in r750993 and sequel.
Thanks
> When a virtual product is modified, its variants aren't modified
> ----------------------------------------------------------------
>
> Key: OFBIZ-2228
> URL: https://issues.apache.org/jira/browse/OFBIZ-2228
> Project: OFBiz
> Issue Type: New Feature
> Components: framework, product
> Affects Versions: SVN trunk
> Environment: trunk revision 748987
> Reporter: Eric DE MAULDE
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: ServiceVariant_from-virtual.patch
>
>
> I would like modify product Variants from its Virtual Product
> By example, to :
> - add (update / delete) category
> - add (update / delete) price
> - add (update / delete) config
> - add (update / delete) supplier
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2228) When a virtual product is modified,
its variants aren't modified
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679578#action_12679578 ]
Jacques Le Roux commented on OFBIZ-2228:
----------------------------------------
Eric,
Your (modified) patch is in trunk at revision: 750878
I changed the name from ServiceVariantEventHandler to ServiceVariantsEventHandler
In Java, please use
FastList.newInstance()
instead of
new FastList()
(for easier genericity compatibility)
if(UtilValidate.isNotEmpty(request.getParameter("productId"))) {
instead of
if(request.getParameter("productId") != null && request.getParameter("productId").toString().length() > 0){
put a space before { at end of if(..), see http://docs.ofbiz.org/display/OFBADMIN/Coding+Conventions we use http://java.sun.com/docs/codeconv/html/CodeConvTOC.doc.html
Anyway I will soon commit a lot of related changes (not only yours of course) and you will see what I mean in general
Forms : please i18n, l10n, "Modify Variants"
I wait your patch for "Modify Variants" before closing, thanks !
> When a virtual product is modified, its variants aren't modified
> ----------------------------------------------------------------
>
> Key: OFBIZ-2228
> URL: https://issues.apache.org/jira/browse/OFBIZ-2228
> Project: OFBiz
> Issue Type: New Feature
> Components: framework, product
> Affects Versions: SVN trunk
> Environment: trunk revision 748987
> Reporter: Eric DE MAULDE
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: ServiceVariant_from-virtual.patch
>
>
> I would like modify product Variants from its Virtual Product
> By example, to :
> - add (update / delete) category
> - add (update / delete) price
> - add (update / delete) config
> - add (update / delete) supplier
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2228) When a virtual product is modified,
its variants aren't modified
Posted by "Eric DE MAULDE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric DE MAULDE updated OFBIZ-2228:
----------------------------------
Attachment: ServiceVariant_from-virtual.patch
this patch allows to modify each product VARIANTS from its virtual product
(on 2 level : variants and sub-variants).
The new file : ServiceVariantEventHandler.java is called from the Controller
and manage the transaction
> When a virtual product is modified, its variants aren't modified
> ----------------------------------------------------------------
>
> Key: OFBIZ-2228
> URL: https://issues.apache.org/jira/browse/OFBIZ-2228
> Project: OFBiz
> Issue Type: New Feature
> Components: framework, product
> Affects Versions: SVN trunk
> Environment: trunk revision 748987
> Reporter: Eric DE MAULDE
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: ServiceVariant_from-virtual.patch
>
>
> I would like modify product Variants from its Virtual Product
> By example, to :
> - add (update / delete) category
> - add (update / delete) price
> - add (update / delete) config
> - add (update / delete) supplier
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2228) When a virtual product is modified,
its variants aren't modified
Posted by "Vince Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680867#action_12680867 ]
Vince Clark commented on OFBIZ-2228:
------------------------------------
Has been a while since I worked with virtual and variant products. But my recollection is that at least for categories and price you only need this at the virtual level. Unless the price is different for certain variations.
> When a virtual product is modified, its variants aren't modified
> ----------------------------------------------------------------
>
> Key: OFBIZ-2228
> URL: https://issues.apache.org/jira/browse/OFBIZ-2228
> Project: OFBiz
> Issue Type: New Feature
> Components: framework, product
> Affects Versions: SVN trunk
> Environment: trunk revision 748987
> Reporter: Eric DE MAULDE
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: ServiceVariant_from-virtual.patch
>
>
> I would like modify product Variants from its Virtual Product
> By example, to :
> - add (update / delete) category
> - add (update / delete) price
> - add (update / delete) config
> - add (update / delete) supplier
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2228) When a virtual product is modified,
its variants aren't modified
Posted by "Eric DE MAULDE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric DE MAULDE updated OFBIZ-2228:
----------------------------------
Attachment: (was: ServiceVariant_from-virtual.patch)
> When a virtual product is modified, its variants aren't modified
> ----------------------------------------------------------------
>
> Key: OFBIZ-2228
> URL: https://issues.apache.org/jira/browse/OFBIZ-2228
> Project: OFBiz
> Issue Type: New Feature
> Components: framework, product
> Affects Versions: SVN trunk
> Environment: trunk revision 748987
> Reporter: Eric DE MAULDE
> Priority: Trivial
> Fix For: SVN trunk
>
>
> I would like modify product Variants from its Virtual Product
> By example, to :
> - add (update / delete) category
> - add (update / delete) price
> - add (update / delete) config
> - add (update / delete) supplier
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.