You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/10/15 09:05:50 UTC
[GitHub] TisonKun commented on a change in pull request #6841: [FLINK-10405]
[tests] Port JobManagerFailsITCase to new code base
TisonKun commented on a change in pull request #6841: [FLINK-10405] [tests] Port JobManagerFailsITCase to new code base
URL: https://github.com/apache/flink/pull/6841#discussion_r225089055
##########
File path: flink-tests/src/test/java/org/apache/flink/test/recovery/JobManagerHAProcessFailureRecoveryITCase.java
##########
@@ -325,6 +325,21 @@ public void run() {
dispatcherProcesses[1] = new DispatcherProcess(1, config);
dispatcherProcesses[1].startProcess();
+ // get new dispatcher gateway
+ leaderListener.waitForNewLeader(deadline.timeLeft().toMillis());
+
+ leaderAddress = leaderListener.getAddress();
+ leaderId = leaderListener.getLeaderSessionID();
+
+ final CompletableFuture<DispatcherGateway> newDispatcherGatewayFuture = rpcService.connect(
+ leaderAddress,
+ DispatcherId.fromUuid(leaderId),
+ DispatcherGateway.class);
+ final DispatcherGateway newDispatcherGateway = newDispatcherGatewayFuture.get();
+
+ // Wait for all task managers to connect to the new leading job manager
+ waitForTaskManagers(numberOfTaskManagers, newDispatcherGateway, deadline.timeLeft());
Review comment:
Yes of course. I saw the removed test "A TaskManager detect a lost connection to the JobManager and try to reconnect to it" explicitly asserts this and thus add this block. I am not opposite to revert it since it is implicitly
asserted if the jobs finishes successfully.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services