[jira] [Commented] (OFBIZ-4497) OrderChangeHelper.orderStatusChanges and OrderServices.setOrderStatus has duplicate code

["Ashish Vijaywargiya (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213317#comment-14213317 ] 

Ashish Vijaywargiya commented on OFBIZ-4497:
--------------------------------------------

It is not the Bug, Changing its type to Improvement. 

> OrderChangeHelper.orderStatusChanges and OrderServices.setOrderStatus has duplicate code
> ----------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4497
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4497
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>            Reporter: Kiran Gawde
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>
> Both OrderChangeHelper.orderStatusChanges calls changeOrderStatus(OrderServices.setOrderStatus) and then calls  the changeOrderItemStatus. 
> OrderServices.setOrderStatus also calls  the changeOrderItemStatus (which may call changeOrderStatus as well). 
> I think, OrderChangeHelper.orderStatusChanges should be updated so that it doesn't call changeOrderItemStatus.
> Also, OrderServices.setOrderStatus uses hardcoded statuses. Where as OrderChangeHelper.approveOrder looks them up from store. Most places, it is hardcoded (e.g: secas.xml). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)