You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "LucaCappelletti94 (via GitHub)" <gi...@apache.org> on 2026/10/19 13:26:59 UTC
[PR] MySQL: Keep literal prefixes as identifiers after a period [datafusion-sqlparser-rs]
LucaCappelletti94 opened a new pull request, #2688:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2688
MySQL accepts `SELECT t.x'ff' FROM t` as column `x` with alias `ff`, and similarly accepts qualified columns named `b` and `n`. The tokenizer recognizes a prefixed literal after the period, so these queries fail to parse. Qualified-name rules are documented by [MySQL](https://dev.mysql.com/doc/refman/8.4/en/identifiers.html) and [MariaDB](https://mariadb.com/docs/server/reference/sql-structure/sql-language-structure/identifier-names).
`Dialect::supports_literal_prefix_in_qualified_name()` enables identifier tokenization immediately after a period for MySQL and the generic dialect. Whitespace or comments after the period retain literal tokenization, as do unqualified prefixes. Other dialects retain their literal handling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] MySQL: Keep literal prefixes as identifiers after a period [datafusion-sqlparser-rs]
Posted by "LucaCappelletti94 (via GitHub)" <gi...@apache.org>.
LucaCappelletti94 merged PR #2688:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] MySQL: Keep literal prefixes as identifiers after a period [datafusion-sqlparser-rs]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2688:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2688#issuecomment-6270423517
## [Codecov](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2688?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 81.30%. Comparing base ([`d32825d`](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/commit/d32825d6f9c60405af1dbbb8ff06921447abb31b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bb91320`](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/commit/bb91320ab274902c628af2296de3f8d6df517ff5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2688 +/- ##
=======================================
Coverage 81.29% 81.30%
=======================================
Files 42 42
Lines 33950 33963 +13
Branches 33950 33963 +13
=======================================
+ Hits 27601 27614 +13
Misses 2785 2785
Partials 3564 3564
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2688?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org