You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/02/19 16:46:34 UTC

[GitHub] [incubator-nuttx] anchao opened a new pull request #317: time/gmtimer: remove unnecessary definition

anchao opened a new pull request #317: time/gmtimer: remove unnecessary definition
URL: https://github.com/apache/incubator-nuttx/pull/317
 
 
   time/lib_gmtimer.c:54: warning: "SEC_PER_MIN" redefined
      54 | #define SEC_PER_MIN  ((time_t)60)
         |
   In file included from nuttx/include/nuttx/semaphore.h:48,
                    from nuttx/include/pthread.h:56,
                    from nuttx/include/signal.h:50,
                    from nuttx/include/sys/select.h:46,
                    from nuttx/include/sys/types.h:305,
                    from nuttx/include/time.h:46,
                    from time/lib_gmtimer.c:44:
   nuttx/include/nuttx/clock.h:125: note: this is the location of the previous definition
     125 | #define SEC_PER_MIN                   60L
         |
   time/lib_gmtimer.c:55: warning: "SEC_PER_HOUR" redefined
      55 | #define SEC_PER_HOUR ((time_t)60 * SEC_PER_MIN)
         |
   In file included from nuttx/include/nuttx/semaphore.h:48,
                    from nuttx/include/pthread.h:56,
                    from nuttx/include/signal.h:50,
                    from nuttx/include/sys/select.h:46,
                    from nuttx/include/sys/types.h:305,
                    from nuttx/include/time.h:46,
                    from time/lib_gmtimer.c:44:
   nuttx/include/nuttx/clock.h:138: note: this is the location of the previous definition
     138 | #define SEC_PER_HOUR           (SEC_PER_MIN  * MIN_PER_HOUR)
         |
   time/lib_gmtimer.c:56: warning: "SEC_PER_DAY" redefined
      56 | #define SEC_PER_DAY  ((time_t)24 * SEC_PER_HOUR)
         |
   In file included from nuttx/include/nuttx/semaphore.h:48,
                    from nuttx/include/pthread.h:56,
                    from nuttx/include/signal.h:50,
                    from nuttx/include/sys/select.h:46,
                    from nuttx/include/sys/types.h:305,
                    from nuttx/include/time.h:46,
                    from time/lib_gmtimer.c:44:
   nuttx/include/nuttx/clock.h:141: note: this is the location of the previous definition
     141 | #define SEC_PER_DAY            (HOURS_PER_DAY * SEC_PER_HOUR)
         |
   
   Change-Id: Ifde7576d3b19ee094a1cfe81f7ff2e5de5abdacf
   Signed-off-by: chao.an <an...@xiaomi.com>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] Ouss4 commented on issue #317: time/gmtimer: remove unnecessary definition

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on issue #317: time/gmtimer: remove unnecessary definition
URL: https://github.com/apache/incubator-nuttx/pull/317#issuecomment-588421047
 
 
   Was clock.h included by one of the PRs that weren't merged?
   Because as is, the build is broken.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo merged pull request #317: time/gmtimer: remove unnecessary definition

Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #317: time/gmtimer: remove unnecessary definition
URL: https://github.com/apache/incubator-nuttx/pull/317
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services