[GitHub] [druid] abhishekagarwal87 commented on a change in pull request #11426: compaction/status API retains status for datasources that no longer existed causing in-memory used to grow unbounded

[GitBox <gi...@apache.org>]

abhishekagarwal87 commented on a change in pull request #11426:
URL: https://github.com/apache/druid/pull/11426#discussion_r666794296



##########
File path: server/src/main/java/org/apache/druid/server/coordinator/duty/CompactSegments.java
##########
@@ -213,11 +212,11 @@ public DruidCoordinatorRuntimeParams run(DruidCoordinatorRuntimeParams params)
         }
       } else {
         LOG.info("compactionConfig is empty. Skip.");
-        updateAutoCompactionSnapshotWhenNoCompactTaskScheduled(currentRunAutoCompactionSnapshotBuilders);
+        autoCompactionSnapshotPerDataSource.set(new HashMap<>());

Review comment:
       just want to confirm. this will trigger when there is no compaction config for any datasource, right? If there are other datasources eligible for compaction and some are in-active, would this still be called? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org