You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@baremaps.apache.org by "swerky (via GitHub)" <gi...@apache.org> on 2023/03/17 10:59:56 UTC
[GitHub] [incubator-baremaps] swerky opened a new issue, #609: Test `IpLocTest findAll` failed
swerky opened a new issue, #609:
URL: https://github.com/apache/incubator-baremaps/issues/609
> I have a failed test `IpLocTest.findAll:94 expected: <7> but was: <6>` with maven 3.8.1, java 17.0.2-oracle will running a `mvn clean install`. I have not looked why this test failed for the moment.
> James
https://lists.apache.org/thread/mo9y0nmf9fvnc4n91hyw1z0p08hl6j8f
With:
- macOS 13.2
- maven 3.8.1
- java 17.0.2-oracle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-baremaps] swerky closed issue #609: Test `IpLocTest findAll` failed
Posted by "swerky (via GitHub)" <gi...@apache.org>.
swerky closed issue #609: Test `IpLocTest findAll` failed
URL: https://github.com/apache/incubator-baremaps/issues/609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-baremaps] swerky commented on issue #609: Test `IpLocTest findAll` failed
Posted by "swerky (via GitHub)" <gi...@apache.org>.
swerky commented on issue #609:
URL: https://github.com/apache/incubator-baremaps/issues/609#issuecomment-1473678324
I found what the problem is:
It's this test value that is not correctly mapped to a `InetnumLocation`:
```
inetnum: 0.0.0.11 - 0.0.0.20
netname: Suisse
country: CH
note: Test with country code only
```
In [the IpLoc.java](./baremaps-core/src/main/java/org/apache/baremaps/iploc/IpLoc.java) we use `IsoCountriesUtils.getCountry` and on my machine, it returns `Suisse` and not `Switzerland` this is due to my operating system being in french.
@bchapuis Should we have this information somewhere in the README? Futur users won't be able to build the app if their system is not in English.
Or should we change this test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-baremaps] swerky commented on issue #609: Test `IpLocTest findAll` failed
Posted by "swerky (via GitHub)" <gi...@apache.org>.
swerky commented on issue #609:
URL: https://github.com/apache/incubator-baremaps/issues/609#issuecomment-1473662495
I tried to change the JVM to see if it was the oracle version problem.
I tried with `17.0.6-tem` and still the same problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org