You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/09 16:09:27 UTC

[GitHub] [airflow] davlum opened a new pull request #7114: [AIRFLOW-5413] Refactor worker config

davlum opened a new pull request #7114: [AIRFLOW-5413] Refactor worker config
URL: https://github.com/apache/airflow/pull/7114
 
 
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   - [X] Description above provides context of the change
   - [X] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [X] Unit tests coverage for changes (not needed for documentation changes)
   - [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [X] Relevant documentation is updated including usage instructions.
   - [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on issue #7114: [AIRFLOW-5413] Refactor worker config

Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #7114: [AIRFLOW-5413] Refactor worker config
URL: https://github.com/apache/airflow/pull/7114#issuecomment-572666310
 
 
   I have rebased and force-pushed your branch.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7114: [AIRFLOW-5413] Refactor worker config

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7114: [AIRFLOW-5413] Refactor worker config
URL: https://github.com/apache/airflow/pull/7114#issuecomment-572704946
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7114?src=pr&el=h1) Report
   > Merging [#7114](https://codecov.io/gh/apache/airflow/pull/7114?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/c880221d76cf21c86ecdd24d1d423b78d6ceb32d?src=pr&el=desc) will **increase** coverage by `0.01%`.
   > The diff coverage is `97.7%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7114/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7114?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7114      +/-   ##
   ==========================================
   + Coverage   85.23%   85.24%   +0.01%     
   ==========================================
     Files         682      682              
     Lines       39045    39092      +47     
   ==========================================
   + Hits        33280    33324      +44     
   - Misses       5765     5768       +3
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7114?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/kubernetes/worker\_configuration.py](https://codecov.io/gh/apache/airflow/pull/7114/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3dvcmtlcl9jb25maWd1cmF0aW9uLnB5) | `99.29% <100%> (-0.01%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7114/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `98.78% <100%> (+0.03%)` | :arrow_up: |
   | [airflow/executors/kubernetes\_executor.py](https://codecov.io/gh/apache/airflow/pull/7114/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMva3ViZXJuZXRlc19leGVjdXRvci5weQ==) | `57.66% <100%> (+0.09%)` | :arrow_up: |
   | [airflow/kubernetes/pod\_generator.py](https://codecov.io/gh/apache/airflow/pull/7114/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9nZW5lcmF0b3IucHk=) | `95.95% <97.46%> (+0.64%)` | :arrow_up: |
   | [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/7114/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.03% <0%> (-0.69%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7114?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7114?src=pr&el=footer). Last update [c880221...622da42](https://codecov.io/gh/apache/airflow/pull/7114?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] dimberman merged pull request #7114: [AIRFLOW-5413] Refactor worker config

Posted by GitBox <gi...@apache.org>.
dimberman merged pull request #7114: [AIRFLOW-5413] Refactor worker config
URL: https://github.com/apache/airflow/pull/7114
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services