You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "beliefer (via GitHub)" <gi...@apache.org> on 2025/03/20 09:14:30 UTC

[PR] [hotfix] Correct the comments for FlinkSecurityManager [flink]

beliefer opened a new pull request, #26325:
URL: https://github.com/apache/flink/pull/26325

   ## What is the purpose of the change
   
   This PR aim to correct the comments for `FlinkSecurityManager`.
   The original comments means cannot avoid the overhead. It is wrong.
   
   
   ## Brief change log
   
   Correct the comments for `FlinkSecurityManager`
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [hotfix] Correct the comments for FlinkSecurityManager [flink]

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #26325:
URL: https://github.com/apache/flink/pull/26325#issuecomment-2740397413

   ping @hwanju @rmetzger cc @1996fanrui @davidradl @nilmadhab 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [hotfix] Correct the comments for FlinkSecurityManager [flink]

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on code in PR #26325:
URL: https://github.com/apache/flink/pull/26325#discussion_r2006757937


##########
flink-core/src/main/java/org/apache/flink/core/security/FlinkSecurityManager.java:
##########
@@ -89,8 +89,8 @@ static FlinkSecurityManager fromConfiguration(Configuration configuration) {
 
         boolean haltOnSystemExit = configuration.get(ClusterOptions.HALT_ON_FATAL_ERROR);
 
-        // If no check is needed, return null so that caller can avoid setting security manager not
-        // to incur any runtime cost.
+        // If no check is needed, return null so that caller can avoid setting security manager and

Review Comment:
   Yes, the `javadoc` seems good enough. I think this inner comments just for readability.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [hotfix] Correct the comments for FlinkSecurityManager [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #26325:
URL: https://github.com/apache/flink/pull/26325#issuecomment-2739730002

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "039fa334d4ad2221ba042e89c6591ce25ed2f9e7",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "039fa334d4ad2221ba042e89c6591ce25ed2f9e7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 039fa334d4ad2221ba042e89c6591ce25ed2f9e7 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [hotfix] Correct the comments for FlinkSecurityManager [flink]

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #26325:
URL: https://github.com/apache/flink/pull/26325#issuecomment-2751135823

   cc @xintongsong 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [hotfix] Correct the comments for FlinkSecurityManager [flink]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26325:
URL: https://github.com/apache/flink/pull/26325#issuecomment-4333104110

   This PR is being marked as stale since it has not had any activity in the last 90 days. 
   If you would like to keep this PR alive, please leave a comment asking for a review. 
   If the PR has merge conflicts, update it with the latest from the base branch.
   
   If you are having difficulty finding a reviewer, please reach out to the 
   community, contact details can be found here: https://flink.apache.org/what-is-flink/community/
   
   If this PR is no longer valid or desired, please feel free to close it. 
   If no activity occurs in the next 30 days, it will be automatically closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [hotfix] Correct the comments for FlinkSecurityManager [flink]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26325:
URL: https://github.com/apache/flink/pull/26325#issuecomment-5101089062

   This PR is being marked as stale since it has not had any activity in the last 90 days. 
   If you would like to keep this PR alive, please leave a comment asking for a review. 
   If the PR has merge conflicts, update it with the latest from the base branch.
   
   If you are having difficulty finding a reviewer, please reach out to the 
   community, contact details can be found here: https://flink.apache.org/what-is-flink/community/
   
   If this PR is no longer valid or desired, please feel free to close it. 
   If no activity occurs in the next 30 days, it will be automatically closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [hotfix] Correct the comments for FlinkSecurityManager [flink]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #26325: [hotfix] Correct the comments for FlinkSecurityManager
URL: https://github.com/apache/flink/pull/26325


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [hotfix] Correct the comments for FlinkSecurityManager [flink]

Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #26325:
URL: https://github.com/apache/flink/pull/26325#discussion_r2005949148


##########
flink-core/src/main/java/org/apache/flink/core/security/FlinkSecurityManager.java:
##########
@@ -89,8 +89,8 @@ static FlinkSecurityManager fromConfiguration(Configuration configuration) {
 
         boolean haltOnSystemExit = configuration.get(ClusterOptions.HALT_ON_FATAL_ERROR);
 
-        // If no check is needed, return null so that caller can avoid setting security manager not
-        // to incur any runtime cost.
+        // If no check is needed, return null so that caller can avoid setting security manager and

Review Comment:
   nit: security manager -> the security manager
   imho:  I am not too worried about the text here - as the method javadoc seems to cover this. I would be inclined to remove this comment as it adds nothing to the javadoc. If we want to improve it, it would be better to have this comment explain why these if conditions indicate that we should not return a FlinkSecurityManager.
   
   
    - but if we change it here we should use the same words in the methods javadoc.
    
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [hotfix] Correct the comments for FlinkSecurityManager [flink]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26325:
URL: https://github.com/apache/flink/pull/26325#issuecomment-5437016490

   This PR has been closed since it has not had any activity in 120 days. 
   If you feel like this was a mistake, or you would like to continue working on it, 
   please feel free to re-open the PR and ask for a review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [hotfix] Correct the comments for FlinkSecurityManager [flink]

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #26325:
URL: https://github.com/apache/flink/pull/26325#issuecomment-2747584243

   cc @GOODBOY008 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [hotfix] Correct the comments for FlinkSecurityManager [flink]

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #26325:
URL: https://github.com/apache/flink/pull/26325#issuecomment-2808518663

   @1996fanrui Could you take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [hotfix] Correct the comments for FlinkSecurityManager [flink]

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #26325:
URL: https://github.com/apache/flink/pull/26325#issuecomment-2893538744

   ping @hwanju @rmetzger @zentol 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [hotfix] Correct the comments for FlinkSecurityManager [flink]

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #26325:
URL: https://github.com/apache/flink/pull/26325#issuecomment-2978837303

   cc @snuyanzin 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org