You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/11 03:25:27 UTC
[GitHub] [flink] wangyang0918 commented on a change in pull request #14597: [FLINK-20905][k8s] Format the description of 'kubernetes.container.image' option
wangyang0918 commented on a change in pull request #14597:
URL: https://github.com/apache/flink/pull/14597#discussion_r554672276
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##########
@@ -195,9 +196,16 @@
.stringType()
.defaultValue(getDefaultFlinkImage())
.withDescription(
- "Image to use for Flink containers. "
- + "The specified image must be based upon the same Apache Flink and Scala versions as used by the application. "
- + "Visit https://hub.docker.com/_/flink?tab=tags for the official docker images provided by the Flink project. The Flink project also publishes docker images here: https://hub.docker.com/r/apache/flink");
+ Description.builder()
+ .text(
+ "Image to use for Flink containers. "
+ + "The specified image must be based upon the same Apache Flink and Scala versions as used by the application. "
+ + "Visit %s for the official docker images provided by the Flink project. The Flink project also publishes docker images to %s.",
+ link("https://hub.docker.com/_/flink?tab=tags", "here"),
+ link(
+ "https://hub.docker.com/r/apache/flink",
+ "DockerHub"))
Review comment:
```suggestion
"apache/flink DockerHub repository"))
```
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##########
@@ -195,9 +196,16 @@
.stringType()
.defaultValue(getDefaultFlinkImage())
.withDescription(
- "Image to use for Flink containers. "
- + "The specified image must be based upon the same Apache Flink and Scala versions as used by the application. "
- + "Visit https://hub.docker.com/_/flink?tab=tags for the official docker images provided by the Flink project. The Flink project also publishes docker images here: https://hub.docker.com/r/apache/flink");
+ Description.builder()
+ .text(
+ "Image to use for Flink containers. "
+ + "The specified image must be based upon the same Apache Flink and Scala versions as used by the application. "
+ + "Visit %s for the official docker images provided by the Flink project. The Flink project also publishes docker images to %s.",
+ link("https://hub.docker.com/_/flink?tab=tags", "here"),
+ link(
+ "https://hub.docker.com/r/apache/flink",
+ "DockerHub"))
Review comment:
Maybe using "apache/flink DockerHub repository" is better since the official docker images are also located in the DockerHub.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org