You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Wei Zhou <w....@leaseweb.com> on 2013/04/12 08:33:56 UTC
Review Request: (CLOUDSTACK-2017) implement network bandwidth rate limits
for VMs for KVM
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10428/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
Adding bandwidth inbound and outbound limitations in VM XML file to implement network bandwidth rate limits for VMs for KVM.
It is supported since libvirt 0.9.4.
The patch only applies on CloudStack 4.0.1 branch.
If commited, I will change it to support 4.1 and master branch.
This addresses bug CLOUDSTACK-2017.
Diffs
-----
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java f406c86
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java b622b6d
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java ba6c715
Diff: https://reviews.apache.org/r/10428/diff/
Testing
-------
Testing manually ok.
The VMs need to stop and start to make network bandwidth limits effective.
Thanks,
Wei Zhou
Re: Review Request: (CLOUDSTACK-2017) implement network bandwidth rate
limits for VMs for KVM
Posted by Wei Zhou <w....@leaseweb.com>.
> On April 12, 2013, 1:27 p.m., Chip Childers wrote:
> > Wei,
> >
> > Any chance you can provide unit tests and / or a marvin test that covers this functionality? I know it's a bit of an odd part of the code to have an automated test for, but we'd love to see something added with each incremental functional change we make.
> >
> > -chip
>
> Prasanna Santhanam wrote:
> Wido has setup some basic tests over which one can build further unit-tests. Checkout LibvirtVMDefTest.java in plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource
Prasanna, Thanks.
Chip, it is just an implementation, not a new feature. For new features in future, I will provide unit tests for automated testing.
- Wei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10428/#review19072
-----------------------------------------------------------
On April 12, 2013, 6:33 a.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10428/
> -----------------------------------------------------------
>
> (Updated April 12, 2013, 6:33 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Adding bandwidth inbound and outbound limitations in VM XML file to implement network bandwidth rate limits for VMs for KVM.
> It is supported since libvirt 0.9.4.
>
> The patch only applies on CloudStack 4.0.1 branch.
> If commited, I will change it to support 4.1 and master branch.
>
>
> This addresses bug CLOUDSTACK-2017.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java f406c86
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java b622b6d
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java ba6c715
>
> Diff: https://reviews.apache.org/r/10428/diff/
>
>
> Testing
> -------
>
> Testing manually ok.
> The VMs need to stop and start to make network bandwidth limits effective.
>
>
> Thanks,
>
> Wei Zhou
>
>
Re: Review Request: (CLOUDSTACK-2017) implement network bandwidth rate
limits for VMs for KVM
Posted by Prasanna Santhanam <Pr...@citrix.com>.
> On April 12, 2013, 1:27 p.m., Chip Childers wrote:
> > Wei,
> >
> > Any chance you can provide unit tests and / or a marvin test that covers this functionality? I know it's a bit of an odd part of the code to have an automated test for, but we'd love to see something added with each incremental functional change we make.
> >
> > -chip
Wido has setup some basic tests over which one can build further unit-tests. Checkout LibvirtVMDefTest.java in plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource
- Prasanna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10428/#review19072
-----------------------------------------------------------
On April 12, 2013, 6:33 a.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10428/
> -----------------------------------------------------------
>
> (Updated April 12, 2013, 6:33 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Adding bandwidth inbound and outbound limitations in VM XML file to implement network bandwidth rate limits for VMs for KVM.
> It is supported since libvirt 0.9.4.
>
> The patch only applies on CloudStack 4.0.1 branch.
> If commited, I will change it to support 4.1 and master branch.
>
>
> This addresses bug CLOUDSTACK-2017.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java f406c86
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java b622b6d
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java ba6c715
>
> Diff: https://reviews.apache.org/r/10428/diff/
>
>
> Testing
> -------
>
> Testing manually ok.
> The VMs need to stop and start to make network bandwidth limits effective.
>
>
> Thanks,
>
> Wei Zhou
>
>
Re: Review Request: (CLOUDSTACK-2017) implement network bandwidth rate
limits for VMs for KVM
Posted by Chip Childers <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10428/#review19072
-----------------------------------------------------------
Wei,
Any chance you can provide unit tests and / or a marvin test that covers this functionality? I know it's a bit of an odd part of the code to have an automated test for, but we'd love to see something added with each incremental functional change we make.
-chip
- Chip Childers
On April 12, 2013, 6:33 a.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10428/
> -----------------------------------------------------------
>
> (Updated April 12, 2013, 6:33 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Adding bandwidth inbound and outbound limitations in VM XML file to implement network bandwidth rate limits for VMs for KVM.
> It is supported since libvirt 0.9.4.
>
> The patch only applies on CloudStack 4.0.1 branch.
> If commited, I will change it to support 4.1 and master branch.
>
>
> This addresses bug CLOUDSTACK-2017.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java f406c86
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java b622b6d
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java ba6c715
>
> Diff: https://reviews.apache.org/r/10428/diff/
>
>
> Testing
> -------
>
> Testing manually ok.
> The VMs need to stop and start to make network bandwidth limits effective.
>
>
> Thanks,
>
> Wei Zhou
>
>
Re: Review Request 10428: (CLOUDSTACK-2017) implement network bandwidth rate
limits for VMs for KVM
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10428/#review24860
-----------------------------------------------------------
Commit a77f77c07505856fbaf438646d590a3f984d05c2 in branch refs/heads/4.1 from Wei Zhou
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a77f77c ]
CLOUDSTACK-2017: network throttling implementation for KVM
- ASF Subversion and Git Services
On April 12, 2013, 6:33 a.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10428/
> -----------------------------------------------------------
>
> (Updated April 12, 2013, 6:33 a.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-2017
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding bandwidth inbound and outbound limitations in VM XML file to implement network bandwidth rate limits for VMs for KVM.
> It is supported since libvirt 0.9.4.
>
> The patch only applies on CloudStack 4.0.1 branch.
> If commited, I will change it to support 4.1 and master branch.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java f406c86
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java b622b6d
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java ba6c715
>
> Diff: https://reviews.apache.org/r/10428/diff/
>
>
> Testing
> -------
>
> Testing manually ok.
> The VMs need to stop and start to make network bandwidth limits effective.
>
>
> Thanks,
>
> Wei Zhou
>
>
Re: Review Request: (CLOUDSTACK-2017) implement network bandwidth rate
limits for VMs for KVM
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10428/#review22160
-----------------------------------------------------------
Commit 289939580815c46cc2e162a7e6e232a4977a7950 in branch refs/heads/master from Wei Zhou
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2899395 ]
CLOUDSTACK-2017: network throttling implementation for KVM
- ASF Subversion and Git Services
On April 12, 2013, 6:33 a.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10428/
> -----------------------------------------------------------
>
> (Updated April 12, 2013, 6:33 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Adding bandwidth inbound and outbound limitations in VM XML file to implement network bandwidth rate limits for VMs for KVM.
> It is supported since libvirt 0.9.4.
>
> The patch only applies on CloudStack 4.0.1 branch.
> If commited, I will change it to support 4.1 and master branch.
>
>
> This addresses bug CLOUDSTACK-2017.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java f406c86
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java b622b6d
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java ba6c715
>
> Diff: https://reviews.apache.org/r/10428/diff/
>
>
> Testing
> -------
>
> Testing manually ok.
> The VMs need to stop and start to make network bandwidth limits effective.
>
>
> Thanks,
>
> Wei Zhou
>
>