You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Ethan Rose (Jira)" <ji...@apache.org> on 2023/02/15 19:15:00 UTC

[jira] [Created] (HDDS-7977) Use different types for healthy and unhealthy RatisReplicaCount classes

Ethan Rose created HDDS-7977:
--------------------------------

             Summary: Use different types for healthy and unhealthy RatisReplicaCount classes
                 Key: HDDS-7977
                 URL: https://issues.apache.org/jira/browse/HDDS-7977
             Project: Apache Ozone
          Issue Type: Sub-task
          Components: SCM
            Reporter: Ethan Rose


Jira filed from [this comment|https://github.com/apache/ozone/pull/4227#pullrequestreview-1288064161]

In HDDS-7847 a boolean was added to determine whether {{RatisContainerReplicaCount}} should account for unhealthy replicas or not. This changes the behavior of the class such that instances with the boolean set to true or false will behave differently. To prevent dev errors using an unhealthy instance when a healthy one is expected and vice-versa, it would be better to use inheritance and two separate types here instead of the boolean.

As part of this task, we can also fork the {{RatisContainerReplicaCount}} for use with the Legacy RM so it does not hinder progress in the new RM which behaves differently.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org