[GitHub] [mesos] brugidou commented on a change in pull request #345: Allow `mesos task exec/attach` for any task_id

[GitBox <gi...@apache.org>]

brugidou commented on a change in pull request #345: Allow `mesos task exec/attach` for any task_id
URL: https://github.com/apache/mesos/pull/345#discussion_r343619740
 
 

 ##########
 File path: src/python/cli_new/lib/cli/http.py
 ##########
 @@ -41,6 +41,8 @@ def read_endpoint(addr, endpoint):
 
     try:
         url = "{addr}/{endpoint}".format(addr=addr, endpoint=endpoint)
+        if query is not None:
+          url += "?{query}".format(query=urllib.parse.urlencode(query))
 
 Review comment:
   I fixed all the linting, and added a commit to fix an optional parameter ordering issue.
   
   However I was not able to pass tests before my changes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services