You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/05/02 02:15:51 UTC
[GitHub] [iotdb] HeimingZ opened a new pull request, #5763: [IOTDB-3034] Partial insert in new cluster
HeimingZ opened a new pull request, #5763:
URL: https://github.com/apache/iotdb/pull/5763
Log warn info in the data node and return success to the client when partial insert exists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HeimingZ commented on a diff in pull request #5763: [IOTDB-3034] Partial insert in new cluster
Posted by GitBox <gi...@apache.org>.
HeimingZ commented on code in PR #5763:
URL: https://github.com/apache/iotdb/pull/5763#discussion_r862625297
##########
server/src/main/java/org/apache/iotdb/db/mpp/sql/planner/plan/node/write/InsertRowNode.java:
##########
@@ -223,7 +209,7 @@ public void transferType(List<MeasurementSchema> measurementSchemas)
for (int i = 0; i < measurementSchemas.size(); i++) {
if (measurementSchemas.get(i) == null) {
Review Comment:
I'm also confused about this. @MrQuansy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin commented on a diff in pull request #5763: [IOTDB-3034] Partial insert in new cluster
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on code in PR #5763:
URL: https://github.com/apache/iotdb/pull/5763#discussion_r862605187
##########
server/src/main/java/org/apache/iotdb/db/mpp/sql/planner/plan/node/write/InsertRowNode.java:
##########
@@ -172,17 +173,16 @@ public boolean validateSchema(SchemaTree schemaTree) {
return false;
}
} else {
- // todo partial insert
if (deviceSchemaInfo.isAligned() != isAligned) {
return false;
}
for (int i = 0; i < measurementSchemas.size(); i++) {
if (dataTypes[i] != measurementSchemas.get(i).getType()) {
- if (IoTDBDescriptor.getInstance().getConfig().isEnablePartialInsert()) {
+ if (!IoTDBDescriptor.getInstance().getConfig().isEnablePartialInsert()) {
Review Comment:
add a test case
##########
server/src/main/java/org/apache/iotdb/db/mpp/sql/planner/plan/node/write/InsertRowNode.java:
##########
@@ -223,7 +209,7 @@ public void transferType(List<MeasurementSchema> measurementSchemas)
for (int i = 0; i < measurementSchemas.size(); i++) {
if (measurementSchemas.get(i) == null) {
Review Comment:
what is equal to null mean? add javadoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou merged pull request #5763: [IOTDB-3034] Partial insert in new cluster
Posted by GitBox <gi...@apache.org>.
HTHou merged PR #5763:
URL: https://github.com/apache/iotdb/pull/5763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a diff in pull request #5763: [IOTDB-3034] Partial insert in new cluster
Posted by GitBox <gi...@apache.org>.
HTHou commented on code in PR #5763:
URL: https://github.com/apache/iotdb/pull/5763#discussion_r862627677
##########
server/src/main/java/org/apache/iotdb/db/mpp/sql/planner/plan/node/write/InsertRowNode.java:
##########
@@ -172,17 +173,16 @@ public boolean validateSchema(SchemaTree schemaTree) {
return false;
}
} else {
- // todo partial insert
if (deviceSchemaInfo.isAligned() != isAligned) {
return false;
}
for (int i = 0; i < measurementSchemas.size(); i++) {
if (dataTypes[i] != measurementSchemas.get(i).getType()) {
- if (IoTDBDescriptor.getInstance().getConfig().isEnablePartialInsert()) {
+ if (!IoTDBDescriptor.getInstance().getConfig().isEnablePartialInsert()) {
Review Comment:
We don't have IT for new cluster yet. For now, UT is enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HeimingZ commented on a diff in pull request #5763: [IOTDB-3034] Partial insert in new cluster
Posted by GitBox <gi...@apache.org>.
HeimingZ commented on code in PR #5763:
URL: https://github.com/apache/iotdb/pull/5763#discussion_r862623157
##########
server/src/main/java/org/apache/iotdb/db/mpp/sql/planner/plan/node/write/InsertRowNode.java:
##########
@@ -172,17 +173,16 @@ public boolean validateSchema(SchemaTree schemaTree) {
return false;
}
} else {
- // todo partial insert
if (deviceSchemaInfo.isAligned() != isAligned) {
return false;
}
for (int i = 0; i < measurementSchemas.size(); i++) {
if (dataTypes[i] != measurementSchemas.get(i).getType()) {
- if (IoTDBDescriptor.getInstance().getConfig().isEnablePartialInsert()) {
+ if (!IoTDBDescriptor.getInstance().getConfig().isEnablePartialInsert()) {
Review Comment:
UT or IT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org