You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/01 11:13:48 UTC
[GitHub] [incubator-nuttx] GUIDINGLI opened a new pull request #4012: fs: move out nx_close from filelock
GUIDINGLI opened a new pull request #4012:
URL: https://github.com/apache/incubator-nuttx/pull/4012
## Summary
fs: move out nx_close from filelock
## Impact
file_close
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4012: fs: move out nx_close from filelock
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4012:
URL: https://github.com/apache/incubator-nuttx/pull/4012#issuecomment-873352834
Fix here: https://github.com/apache/incubator-nuttx/pull/4051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea removed a comment on pull request #4012: fs: move out nx_close from filelock
Posted by GitBox <gi...@apache.org>.
jerpelea removed a comment on pull request #4012:
URL: https://github.com/apache/incubator-nuttx/pull/4012#issuecomment-873356530
please add commit message!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4012: fs: move out nx_close from filelock
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4012:
URL: https://github.com/apache/incubator-nuttx/pull/4012#issuecomment-873357662
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] GUIDINGLI commented on pull request #4012: fs: move out nx_close from filelock
Posted by GitBox <gi...@apache.org>.
GUIDINGLI commented on pull request #4012:
URL: https://github.com/apache/incubator-nuttx/pull/4012#issuecomment-872686666
> @GUIDINGLI What problem is is solving how was it tested?
If someone close blocked, like net close timeout 5s, then in this 5s other file operation can't access
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #4012: fs: move out nx_close from filelock
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #4012:
URL: https://github.com/apache/incubator-nuttx/pull/4012#issuecomment-872555509
@GUIDINGLI What problem is is solving how was it tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #4012: fs: move out nx_close from filelock
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #4012:
URL: https://github.com/apache/incubator-nuttx/pull/4012#issuecomment-873356530
please add commit message!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4012: fs: move out nx_close from filelock
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #4012:
URL: https://github.com/apache/incubator-nuttx/pull/4012
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #4012: fs: move out nx_close from filelock
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #4012:
URL: https://github.com/apache/incubator-nuttx/pull/4012#issuecomment-873083423
> > @GUIDINGLI What problem is is solving how was it tested?
>
> If someone close blocked, like net close timeout 5s, then in this 5s other file operation can't access
Thank you! Always adding this sort of context in the summary would be appreciated.
The CI failure is real.
https://github.com/apache/incubator-nuttx/runs/2961866033#step:7:132
You could try possibly `CONFIG_LIBC_STRERROR=n`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org