You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by al...@apache.org on 2022/11/15 01:09:57 UTC

[datasketches-cpp] branch engagement_unused_vars created (now 0661d69)

This is an automated email from the ASF dual-hosted git repository.

alsay pushed a change to branch engagement_unused_vars
in repository https://gitbox.apache.org/repos/asf/datasketches-cpp.git


      at 0661d69  removed unused variables

This branch includes the following new commits:

     new 0661d69  removed unused variables

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org


[datasketches-cpp] 01/01: removed unused variables

Posted by al...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

alsay pushed a commit to branch engagement_unused_vars
in repository https://gitbox.apache.org/repos/asf/datasketches-cpp.git

commit 0661d69cf93bbea7f490640ddd6fd4bd6f37db65
Author: AlexanderSaydakov <Al...@users.noreply.github.com>
AuthorDate: Mon Nov 14 17:09:27 2022 -0800

    removed unused variables
---
 tuple/test/engagement_test.cpp | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/tuple/test/engagement_test.cpp b/tuple/test/engagement_test.cpp
index 9f315cb..05d5cfc 100644
--- a/tuple/test/engagement_test.cpp
+++ b/tuple/test/engagement_test.cpp
@@ -42,7 +42,7 @@ class always_one_policy {
 public:
     always_one_policy(): initial_value(1) {}
     T create() const { return 1; }
-    void update(T& summary, const T& update) const { }
+    void update(T&, const T&) const { }
 private:
     T initial_value;
 };
@@ -216,13 +216,8 @@ private:
         auto union_result = u.get_result() ;
         std::vector<uint64_t> num_days_arr(num_sketches+1) ;
 
-        int num_retained = 0 ;
-        int total_sum = 0 ;
-
         for (const auto& entry: union_result) {
             int num_days_visited = entry.second ;
-            num_retained++ ;
-            total_sum += entry.second ;
             num_days_arr[num_days_visited]++;
         }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org