You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "xiangfu0 (via GitHub)" <gi...@apache.org> on 2026/10/14 22:04:37 UTC

[PR] Deprecate pinot-yammer and document Dropwizard migration [pinot]

xiangfu0 opened a new pull request, #19872:
URL: https://github.com/apache/pinot/pull/19872

   Marks the `pinot-yammer` Maven artifact and `YammerMetricsFactory` deprecated since Pinot 1.6.0, directing users to the existing `pinot-dropwizard` backend.
   
   Adds a module migration guide with configuration examples for broker, controller, server, and minion, plugin availability and restart steps, monitoring compatibility checks, and rollback instructions. Existing factory selection and distribution packaging are preserved; the default switch and removal timeline remain tracked separately in #19871.
   
   Validation:
   
   - `spotless:apply`, `license:format`, `checkstyle:check`, and `license:check` passed for `pinot-yammer`.
   - `./mvnw test-compile -pl pinot-plugins/pinot-metrics/pinot-yammer -am -Dmaven.compiler.showDeprecation=true -Dmaven.compiler.showWarnings=true` passed.
   - Verified the four documented service properties and replacement factory against the source.
   - No tests or benchmarks added; changes are limited to the deprecation annotation, metadata, and documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Make Dropwizard metrics the default and deprecate pinot-yammer [pinot]

Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on code in PR #19872:
URL: https://github.com/apache/pinot/pull/19872#discussion_r4278319904


##########
docker/images/pinot/etc/jmx_prometheus_javaagent/configs-dropwizard/server.yml:
##########
@@ -0,0 +1,182 @@
+rules:
+# Dropwizard gauges expose both Value and Number; retain the existing Value series only.
+- pattern: "\"?org\\.apache\\.pinot\\.common\\.metrics\"?<name=.*, type=\"?gauges\"?><>Number"
+  name: ""
+# OPEN_STRUCT observability. These MUST precede the generic gauge/meter rules below: the column segment
+# would otherwise be consumed by the "tableNameWithType + partitionId" rule and exported as partition="<column>",
+# and the column-level meters by the "rawTableName" rule as table="<table>.<column>".
+# Per-key gauge. The key is a raw user-supplied JSON key, so it is captured last with a greedy ([^"]+) — it may
+# contain '$', '.', '-' or spaces, all of which are legal in a Prometheus label value. The closing quote is
+# excluded because the trailing "? is optional and a greedy (.+) would otherwise swallow it. The column name
+# cannot contain '.' or '$', so ([^.$"]+) splits the two unambiguously. The sparse column renders as key="__sparse__".
+- pattern: "\"?org\\.apache\\.pinot\\.common\\.metrics\"?<name=\"?pinot\\.server\\.(openStructLastSegmentKeyDocCount)\\.(([^.]+)\\.)?([^.]*)_(OFFLINE|REALTIME)\\.([^.$\"]+)\\$([^\"]+)\"?, type=\"?(?:gauges|meters|timers|counters|histograms)\"?><>(\\w+)"
+  name: "pinot_server_$1_$8"
+  cache: true
+  labels:
+    database: "$3"
+    table: "$2$4"
+    tableType: "$5"
+    column: "$6"
+    key: "$7"
+# Column-level OPEN_STRUCT gauges.
+- pattern: "\"?org\\.apache\\.pinot\\.common\\.metrics\"?<name=\"?pinot\\.server\\.(openStructLastSegmentDenseKeyCount|openStructLastSegmentSparseKeyCount|openStructLastSegmentKeyCount|openStructLastSegmentDocCount)\\.(([^.]+)\\.)?([^.]*)_(OFFLINE|REALTIME)\\.([^.\"]+)\"?, type=\"?(?:gauges|meters|timers|counters|histograms)\"?><>(\\w+)"
+  name: "pinot_server_$1_$7"
+  cache: true
+  labels:
+    database: "$3"
+    table: "$2$4"
+    tableType: "$5"
+    column: "$6"
+# Column-level OPEN_STRUCT meters. Meter names put the metric name last, unlike gauges.
+- pattern: "\"?org\\.apache\\.pinot\\.common\\.metrics\"?<name=\"?pinot\\.server\\.(([^.]+)\\.)?([^.]*)_(OFFLINE|REALTIME)\\.([^.]+)\\.(openStructTypeCoercionFailures|openStructTypeInferenceFailures)\"?, type=\"?(?:gauges|meters|timers|counters|histograms)\"?><>(\\w+)"
+  name: "pinot_server_$6_$7"
+  cache: true
+  labels:
+    database: "$2"
+    table: "$1$3"
+    tableType: "$4"
+    column: "$5"
+# Gauges that accept tableNameWithType
+- pattern: "\"?org\\.apache\\.pinot\\.common\\.metrics\"?<name=\"?pinot\\.(\\w+)\\.(\\w+)\\.((\\w+)\\.)?(\\w+)_(OFFLINE|REALTIME)\\\"?, type=\"?\\w+\"?><>(\\w+)"

Review Comment:
   Minor/consistency: a few server rules use `type="?\w+"?` here while the rest of this file (and all of broker/controller/minion) use the explicit `(?:gauges|meters|timers|counters|histograms)` alternation. No behavioral difference today since `\w+` still matches all five categories — just tidier to make them consistent.



##########
pinot-common/src/test/java/org/apache/pinot/common/metrics/prometheus/PinotPrometheusMetricsTest.java:
##########
@@ -95,6 +95,7 @@ public void setupTest() {
     _pinotMetricsFactory = getPinotMetricsFactory();
     pinotConfiguration.setProperty(CONFIG_OF_METRICS_FACTORY_CLASS_NAME,
         _pinotMetricsFactory.getClass().getCanonicalName());
+    _pinotMetricsFactory.init(pinotConfiguration);

Review Comment:
   Good catch adding this. Worth noting for reviewers why it's needed: the test's own `_pinotMetricsFactory` instance is separate from the one `PinotMetricUtils.init` creates via reflection, so without this `init()` its `_domainName` stays null and `makePinotJmxReporter` would emit under a null domain — the exporter regex keys on `org.apache.pinot.common.metrics`, so the assertions would be vacuous. Legit fix.



##########
docker/images/pinot/etc/jmx_prometheus_javaagent/configs-dropwizard/server.yml:
##########
@@ -0,0 +1,182 @@
+rules:
+# Dropwizard gauges expose both Value and Number; retain the existing Value series only.
+- pattern: "\"?org\\.apache\\.pinot\\.common\\.metrics\"?<name=.*, type=\"?gauges\"?><>Number"

Review Comment:
   Minor: this Number-suppression rule is missing `cache: true`, while the equivalent rule in broker.yml, controller.yml, and minion.yml all have it. The suppression itself works fine — this just means it's re-evaluated per scrape for every numeric gauge MBean. Worth adding `cache: true` for parity and a small scrape-time win.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Make Dropwizard metrics the default and deprecate pinot-yammer [pinot]

Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #19872:
URL: https://github.com/apache/pinot/pull/19872#discussion_r4277925226


##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -49,9 +49,7 @@ private CommonConstants() {
   public static final String CONFIG_OF_BROKER_EVENT_LISTENER_CLASS_NAME = "factory.className";
   public static final String CONFIG_OF_REQUEST_CONTEXT_TRACKED_HEADER_KEYS = "request.context.tracked.header.keys";
   public static final String DEFAULT_METRICS_FACTORY_CLASS_NAME =
-      //"org.apache.pinot.plugin.metrics.compound.CompoundPinotMetricsFactory";
-      "org.apache.pinot.plugin.metrics.yammer.YammerMetricsFactory";
-  //"org.apache.pinot.plugin.metrics.dropwizard.DropwizardMetricsFactory";
+      "org.apache.pinot.plugin.metrics.dropwizard.DropwizardMetricsFactory";

Review Comment:
   [P1] Bound timer reservoirs before switching the default
   
   The default switch activates `DropwizardMetricsRegistry.newTimer()`, which uses `SlidingTimeWindowArrayReservoir(15, TimeUnit.MINUTES)` and retains every observation for 15 minutes, whereas Yammer caps its reservoir at 1,028 samples. At 10,000 updates/sec, one timer retains nine million timestamp/value pairs—at least 144 MB before overhead. Each successful broker query updates table, global, and workload timers (`BaseSingleStageBrokerRequestHandler.java:1076–1081`), plus phase timers. JMX reads also repeatedly copy and sort these populations for individual statistics and percentiles. This materially increases heap usage and scrape costs for existing deployments.
   
   Please use a bounded reservoir, such as Dropwizard's exponentially decaying reservoir, before enabling this backend by default.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Make Dropwizard metrics the default and deprecate pinot-yammer [pinot]

Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on code in PR #19872:
URL: https://github.com/apache/pinot/pull/19872#discussion_r4278069102


##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -49,9 +49,7 @@ private CommonConstants() {
   public static final String CONFIG_OF_BROKER_EVENT_LISTENER_CLASS_NAME = "factory.className";
   public static final String CONFIG_OF_REQUEST_CONTEXT_TRACKED_HEADER_KEYS = "request.context.tracked.header.keys";
   public static final String DEFAULT_METRICS_FACTORY_CLASS_NAME =
-      //"org.apache.pinot.plugin.metrics.compound.CompoundPinotMetricsFactory";
-      "org.apache.pinot.plugin.metrics.yammer.YammerMetricsFactory";
-  //"org.apache.pinot.plugin.metrics.dropwizard.DropwizardMetricsFactory";
+      "org.apache.pinot.plugin.metrics.dropwizard.DropwizardMetricsFactory";

Review Comment:
   Addressed in [f8533e7e49](https://github.com/apache/pinot/commit/f8533e7e493bbae65439bd73de61bad9fdee5a14). Timer creation now uses `MetricRegistry.timer(name)`, whose default exponentially decaying reservoir is bounded at 1,028 samples with alpha 0.015, matching Yammer's sampling parameters.
   
   Added a regression check for 10,000 updates: the full count is preserved and retained samples stay within the bound. A before/after probe confirmed 10,000 retained samples before the fix and 1,028 afterward.
   
   All 1,511 focused tests and the four required precommit checks passed. The real JMX Java-agent scrape smoke also passed with the existing Prometheus names, labels, and millisecond timer values.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Make Dropwizard metrics the default and deprecate pinot-yammer [pinot]

Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on code in PR #19872:
URL: https://github.com/apache/pinot/pull/19872#discussion_r4289882078


##########
pinot-plugins/pinot-metrics/pinot-dropwizard/src/main/java/org/apache/pinot/plugin/metrics/dropwizard/DropwizardMetricsRegistry.java:
##########
@@ -69,8 +69,7 @@ public PinotCounter newCounter(PinotMetricName name) {
 
   @Override
   public PinotTimer newTimer(PinotMetricName name, TimeUnit durationUnit, TimeUnit rateUnit) {
-    Timer timer = _metricRegistry.timer(name.getMetricName().toString(),
-        () -> new Timer(new SlidingTimeWindowArrayReservoir(15, TimeUnit.MINUTES)));
+    Timer timer = _metricRegistry.timer(name.getMetricName().toString());

Review Comment:
   Nit: the timer is now switched to the bounded default reservoir, but `newHistogram` just below still uses `SlidingTimeWindowArrayReservoir(15, TimeUnit.MINUTES)`, so it keeps the same unbounded-growth shape the timer fix removed. In practice nothing in the main codebase calls `newHistogram` today, so this is only a consistency/future-proofing note rather than a real memory risk — worth aligning it with the timer while you're here, or leaving a comment on why it's intentionally left as-is.



##########
docker/images/pinot/etc/jmx_prometheus_javaagent/configs-dropwizard/broker.yml:
##########
@@ -0,0 +1,45 @@
+rules:
+# Dropwizard exposes Number as an alias of Value for numeric gauges.

Review Comment:
   This `name: ""` rule to drop the Dropwizard `Number` alias is a nice touch, but the enabled tests only assert the `Value` series is present — they never assert `Number` is absent, so the suppression itself isn't covered by CI. Could you confirm from an actual scrape (under jmx_exporter 1.7.0) that no `pinot_..._Number` series leaks through? If it ever stops suppressing, the failure is a silent duplicate series rather than a test failure.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Make Dropwizard metrics the default and deprecate pinot-yammer [pinot]

Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #19872:
URL: https://github.com/apache/pinot/pull/19872#discussion_r4288363217


##########
pinot-plugins/pinot-metrics/pinot-yammer/README.md:
##########
@@ -0,0 +1,61 @@
+<!--
+
+    Licensed to the Apache Software Foundation (ASF) under one
+    or more contributor license agreements.  See the NOTICE file
+    distributed with this work for additional information
+    regarding copyright ownership.  The ASF licenses this file
+    to you under the Apache License, Version 2.0 (the
+    "License"); you may not use this file except in compliance
+    with the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing,
+    software distributed under the License is distributed on an
+    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+    KIND, either express or implied.  See the License for the
+    specific language governing permissions and limitations
+    under the License.
+
+-->
+
+# Pinot Yammer metrics (deprecated)
+
+`pinot-yammer` is deprecated since Pinot 1.6.0. Use the existing `pinot-dropwizard` metrics backend instead.
+
+Dropwizard is the default when no metrics factory is configured. Explicit Yammer factory settings still select
+Yammer, which remains bundled. A removal release will be decided separately; see
+[#19871](https://github.com/apache/pinot/issues/19871).
+
+## Migrate to Dropwizard
+
+1. Ensure `pinot-dropwizard` and its runtime dependencies are available to each affected service. Both metrics
+   plugins ship in the standard Pinot binary distribution; custom builds, classpaths, and plugin filters may
+   need to be updated.
+2. Remove explicit Yammer factory settings to use the Dropwizard default, or replace them with the applicable
+   property in each service's configuration file:
+
+   ```properties
+   pinot.broker.metrics.factory.className=org.apache.pinot.plugin.metrics.dropwizard.DropwizardMetricsFactory
+   pinot.controller.metrics.factory.className=org.apache.pinot.plugin.metrics.dropwizard.DropwizardMetricsFactory
+   pinot.server.metrics.factory.className=org.apache.pinot.plugin.metrics.dropwizard.DropwizardMetricsFactory
+   pinot.minion.metrics.factory.className=org.apache.pinot.plugin.metrics.dropwizard.DropwizardMetricsFactory
+   ```
+
+3. To publish a Prometheus scrape endpoint, enable the existing JMX exporter Java agent with
+   `configs-dropwizard/<role>.yml`, where `<role>` is `broker`, `controller`, `server`, or `minion`.
+   If the agent is already enabled, change its YAML path from `configs/<role>.yml` when switching from Yammer.
+   See the
+   [agent startup and scrape configuration](../../../docker/images/pinot/etc/jmx_prometheus_javaagent/README.md#expose-a-scrape-endpoint-with-dropwizard).
+4. Restart each affected service to load the new factory and exporter configuration. Validate the migration in
+   a test environment before rolling it out to production.
+
+The backend-specific role configurations retain the Prometheus metric names and labels for standard Pinot metrics.
+Those timers are reported in milliseconds and meter rates per second with either backend.
+Native JMX names and attributes can differ, as can sampled timer distributions. Validate custom JMX consumers,

Review Comment:
   Document the change from lifetime to sampled timer aggregates
   
   There is a more specific semantic change than sampled distributions differing: Yammer's timer `Min`, `Max`, `Mean`, and `StdDev` are aggregates over all recorded observations, whereas Dropwizard's JMX reporter computes those attributes from its decaying reservoir snapshot. Matching the 1,028-sample capacity and decay factor does not preserve these aggregate semantics. For example, the reported maximum can decrease as an old observation leaves the sample, and the mean is weighted toward recent observations.
   
   These values keep the same exported series names, so existing dashboards and alerts can silently change meaning even after the YAML migration. Please explicitly document this in the migration/release notes and validate the intended behavior with nonconstant, time-separated observations. The shared exporter tests check names and labels, and a constant-duration smoke test cannot distinguish these semantics.



##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -49,9 +49,7 @@ private CommonConstants() {
   public static final String CONFIG_OF_BROKER_EVENT_LISTENER_CLASS_NAME = "factory.className";
   public static final String CONFIG_OF_REQUEST_CONTEXT_TRACKED_HEADER_KEYS = "request.context.tracked.header.keys";
   public static final String DEFAULT_METRICS_FACTORY_CLASS_NAME =
-      //"org.apache.pinot.plugin.metrics.compound.CompoundPinotMetricsFactory";
-      "org.apache.pinot.plugin.metrics.yammer.YammerMetricsFactory";
-  //"org.apache.pinot.plugin.metrics.dropwizard.DropwizardMetricsFactory";
+      "org.apache.pinot.plugin.metrics.dropwizard.DropwizardMetricsFactory";

Review Comment:
   Address the exporter upgrade path before changing the default
   
   An existing deployment with no explicit metrics factory setting and the current `configs/<role>.yml` switches to Dropwizard after upgrading, while retaining exporter rules written for Yammer. Standard Pinot series then stop matching. The new configurations preserve names and labels only after the operator also changes the Java-agent YAML path; direct JMX consumers must adapt to the new ObjectNames/types as well.
   
   The README documents this migration, but an unchanged deployment configuration is still incompatible. Please either provide a compatible exporter transition or stage the default change after a migration/deprecation period. Explicitly retaining Yammer remains a useful rollback path, but existing users must know to configure it before upgrading.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Make Dropwizard metrics the default and deprecate pinot-yammer [pinot]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19872:
URL: https://github.com/apache/pinot/pull/19872#issuecomment-6182808909

   ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/19872?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 0.00%. Comparing base ([`7896d13`](https://app.codecov.io/gh/apache/pinot/commit/7896d13c19c10e02ec605fdb45c70d19f92511a7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f8533e7`](https://app.codecov.io/gh/apache/pinot/commit/f8533e7e493bbae65439bd73de61bad9fdee5a14?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 8 commits behind head on master.
   > :exclamation:  There is a different number of reports uploaded between BASE (7896d13) and HEAD (f8533e7). Click for more details.
   > 
   > <details><summary>HEAD has 14 uploads less than BASE</summary>
   >
   >| Flag | BASE (7896d13) | HEAD (f8533e7) |
   >|------|------|------|
   >|lane-a|2|1|
   >|integration|4|2|
   >|java-25|5|2|
   >|integration1|2|0|
   >|temurin|5|2|
   >|lane-b|2|1|
   >|unittests1|1|0|
   >|unittests|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #19872       +/-   ##
   =============================================
   - Coverage     58.57%    0.00%   -58.58%     
   =============================================
     Files          2722        3     -2719     
     Lines        169962        6   -169956     
     Branches      27944        0    -27944     
   =============================================
   - Hits          99559        0    -99559     
   + Misses        61964        6    -61958     
   + Partials       8439        0     -8439     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/pinot/pull/19872/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [integration](https://app.codecov.io/gh/apache/pinot/pull/19872/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [integration1](https://app.codecov.io/gh/apache/pinot/pull/19872/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [integration2](https://app.codecov.io/gh/apache/pinot/pull/19872/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | |
   | [java-25](https://app.codecov.io/gh/apache/pinot/pull/19872/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (-58.58%)` | :arrow_down: |
   | [lane-a](https://app.codecov.io/gh/apache/pinot/pull/19872/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [lane-b](https://app.codecov.io/gh/apache/pinot/pull/19872/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | |
   | [temurin](https://app.codecov.io/gh/apache/pinot/pull/19872/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (-58.58%)` | :arrow_down: |
   | [unittests](https://app.codecov.io/gh/apache/pinot/pull/19872/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [unittests1](https://app.codecov.io/gh/apache/pinot/pull/19872/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/pinot/pull/19872?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Make Dropwizard metrics the default and deprecate pinot-yammer [pinot]

Posted by "xiangfu0 (via GitHub) via commits" <co...@pinot.apache.org>.
xiangfu0 closed pull request #19872: Make Dropwizard metrics the default and deprecate pinot-yammer
URL: https://github.com/apache/pinot/pull/19872


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org