You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Sun-GLiang (via GitHub)" <gi...@apache.org> on 2026/08/19 13:37:45 UTC
[PR] fix(desktop): reconcile goal.arm after connection loss [maka]
Sun-GLiang opened a new pull request, #3251:
URL: https://github.com/apache/maka/pull/3251
## Summary
- Add a reusable Desktop IPC reconciled-control seam that dispatches a mutation once, then waits for a replacement candidate and runs only the reconciliation query.
- Reconcile dispatched `goal.arm` connection loss against canonical `goal.query` state, including prior Goal identity, normalized condition, effective iteration limit, and token budget.
- Keep the Goal dialog open and locked for reconciled or unavailable outcomes, with Chinese and English copy and stale async-result protection across Session changes.
- Do not change the Runtime Host compatibility epoch, wire codec, or persistence schema.
Fixes #3234
## Verification
- `npm test -w @maka/runtime-host` — 984 passed
- `npm test -w @maka/desktop` — 944 passed
- `npm run typecheck -w @maka/desktop` — passed
- `npm run format:check` — passed
- `npm run lint` — passed
- `npm run e2e -w @maka/desktop -- goal-dialog-budget.spec.ts` — 1 passed
## Dependency
- [ ] #3199 is merged
This Draft PR is based on the current head of #3199. Its diff against `main` therefore includes #3199 until that PR lands. After #3199 merges, this branch will be rebased onto the latest `upstream/main` and the PR will be marked ready for review.
## AI use
Select exactly one:
- [ ] No generative tool made a substantive contribution
- [x] Generative tooling made a substantive contribution
Tool(s) and scope: Codex implemented the Desktop IPC reconciliation seam, `goal.arm` integration, renderer behavior, tests, and verification under user direction.
## Checklist
- [x] Tests cover the change and fail without it
- [x] Lint, format, typecheck and the affected suites pass locally
Does this PR entail a change in behavior?
- [x] Yes — described under Summary above
- [ ] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(desktop): reconcile goal.arm after connection loss [maka]
Posted by "Sun-GLiang (via GitHub)" <gi...@apache.org>.
Sun-GLiang closed pull request #3251: fix(desktop): reconcile goal.arm after connection loss
URL: https://github.com/apache/maka/pull/3251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(desktop): reconcile goal.arm after connection loss [maka]
Posted by "Sun-GLiang (via GitHub)" <gi...@apache.org>.
Sun-GLiang commented on PR #3251:
URL: https://github.com/apache/maka/pull/3251#issuecomment-5364198794
Superseded by #3363, rebuilt from the merged #3199 baseline as a fresh single-commit branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org