You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by dangogh <gi...@git.apache.org> on 2017/05/19 18:22:19 UTC
[GitHub] incubator-trafficcontrol pull request #591: [TC-345] when creating tarball, ...
GitHub user dangogh opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/591
[TC-345] when creating tarball, do not transform symlinks
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dangogh/incubator-trafficcontrol fix/tarball-link
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/591.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #591
----
commit 99f5e005861dc85f05b04dba11e3398e4bf115ed
Author: Dan Kirkwood <da...@gmail.com>
Date: 2017-05-19T18:20:41Z
when creating tarball, do not transform symlinks
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #591: [TC-345] when creating tarball, ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafficcontrol/pull/591
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #591: [TC-345] when creating tarball, do not ...
Posted by dangogh <gi...@git.apache.org>.
Github user dangogh commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/591
to test, build the tarball:
```
$ docker-compose -f infrastructure/docker/build/docker-compose.yml run source
```
and extract the contents. There is one symbolic link -- this is prior to the fix:
```
$ tar xf dist/trafficcontrol-2.1.tar.gz -C /tmp
$ find /tmp/trafficcontrol-incubating-2.1.0 -type l -ls
... /tmp/trafficcontrol-incubating-2.1.0/traffic_stats/vendor/github.com/apache/incubator-trafficcontrol/traffic_ops/client -> trafficcontrol-incubating-2.1.0/../../../../../../traffic_ops/client
```
After applying the fix, build the tarball again and extract contents again. The link content (`trafficcontrol-incubating-2.1.0/../../../../../../traffic_ops/client`) should not have that leading directory name (should be `../../../../../../traffic_ops/client`)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---