[GitHub] [incubator-gobblin] ZihanLi58 commented on a change in pull request #2872: Refactor AbstractYarnSecurityManager to expose method for sending token file update message

[GitBox <gi...@apache.org>]

ZihanLi58 commented on a change in pull request #2872: Refactor AbstractYarnSecurityManager to expose method for sending token file update message
URL: https://github.com/apache/incubator-gobblin/pull/2872#discussion_r367655921
 
 

 ##########
 File path: gobblin-yarn/src/main/java/org/apache/gobblin/yarn/AbstractYarnAppSecurityManager.java
 ##########
 @@ -166,6 +175,15 @@ public void loginAndScheduleTokenRenewal() {
     }
   }
 
+  protected void sendTokenFileUpdatedMessage() {
+    // Send a message to the controller (when the cluster is not managed)
+    // and all the participants if this is not the first login
+    if (!this.isHelixClusterManaged) {
 
 Review comment:
   Why do we only send token file update message to controller when it's not managed? Will helix maintain the token refresh for us?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services