[GitHub] [spark] srowen commented on a diff in pull request #40687: [SPARK-43052][CORE] Handle stacktrace with null file name in event log

["srowen (via GitHub)" <gi...@apache.org>]

srowen commented on code in PR #40687:
URL: https://github.com/apache/spark/pull/40687#discussion_r1174591753


##########
core/src/test/scala/org/apache/spark/util/JsonProtocolSuite.scala:
##########
@@ -904,6 +909,12 @@ private[spark] object JsonProtocolSuite extends Assertions {
     assertEquals(reason, newReason)
   }
 
+  private def testStackTrace(stackTrace: Array[StackTraceElement]): Unit = {

Review Comment:
   Do you need a helper method for this if only used in one place? Not a big deal



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org