You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2022/02/01 20:04:34 UTC

[GitHub] [drill] vvysotskyi commented on a change in pull request #2445: DRILL-8121: Add Partial Support for Per-User Credentials

vvysotskyi commented on a change in pull request #2445:
URL: https://github.com/apache/drill/pull/2445#discussion_r796959949



##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePlugin.java
##########
@@ -62,6 +63,14 @@
   */
   StoragePluginConfig getConfig();
 
+  /**
+   * Sets the user session.
+   * @param session The user session for the query.
+   */
+  void setUserSession(UserSession session);

Review comment:
       I don't think it is safe to set `UserSession` in this way. For the case when we have concurrent queries, `UserSession` from one user could be set, and before it is used, another user can override it...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org