You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2025/11/15 20:15:29 UTC

svn commit: r1929776 - pdfbox/branches/3.0/fontbox/src/test/java/org/apache/fontbox/ttf

Author: tilman
Date: Sat Nov 15 20:15:28 2025
New Revision: 1929776

Log:
PDFBOX-5660: close input, as suggested by Valery Bokov; closes #334

Modified:
   pdfbox/branches/3.0/fontbox/src/test/java/org/apache/fontbox/ttf/GSUBTableDebugger.java

Modified: pdfbox/branches/3.0/fontbox/src/test/java/org/apache/fontbox/ttf/GSUBTableDebugger.java
==============================================================================
--- pdfbox/branches/3.0/fontbox/src/test/java/org/apache/fontbox/ttf/GSUBTableDebugger.java	Sat Nov 15 20:15:24 2025	(r1929775)
+++ pdfbox/branches/3.0/fontbox/src/test/java/org/apache/fontbox/ttf/GSUBTableDebugger.java	Sat Nov 15 20:15:28 2025	(r1929776)
@@ -20,6 +20,7 @@ package org.apache.fontbox.ttf;
 import static org.junit.jupiter.api.Assertions.fail;
 
 import java.io.IOException;
+import java.io.InputStream;
 
 import org.apache.fontbox.ttf.gsub.GSUBTablePrintUtil;
 import org.apache.fontbox.ttf.model.GsubData;
@@ -39,10 +40,10 @@ public class GSUBTableDebugger
     @Test
     void printLohitBengaliTTF()
     {
-        try
+        try(InputStream is1 = GSUBTableDebugger.class.getResourceAsStream(LOHIT_BENGALI_FONT_FILE);
+            InputStream is2 = GSUBTableDebugger.class.getResourceAsStream(LOHIT_BENGALI_FONT_FILE))
         {
-            RandomAccessReadBuffer randomAccessReadBuffer = new RandomAccessReadBuffer(
-                    GSUBTableDebugger.class.getResourceAsStream(LOHIT_BENGALI_FONT_FILE));
+            RandomAccessReadBuffer randomAccessReadBuffer = new RandomAccessReadBuffer(is1);
             RandomAccessReadDataStream randomAccessReadBufferDataStream = new RandomAccessReadDataStream(
                     randomAccessReadBuffer);
     
@@ -53,8 +54,7 @@ public class GSUBTableDebugger
             glyphSubstitutionTable.read(null, randomAccessReadBufferDataStream);
     
             TrueTypeFont trueTypeFont = new TTFParser()
-                    .parse(new RandomAccessReadBuffer(
-                            GSUBTableDebugger.class.getResourceAsStream(LOHIT_BENGALI_FONT_FILE)));
+                    .parse(new RandomAccessReadBuffer(is2));
     
             GsubData gsubData = glyphSubstitutionTable.getGsubData();
             new GSUBTablePrintUtil().printCharacterToGlyph(gsubData,