You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/09/20 20:54:57 UTC

[GitHub] KellenSunderland commented on a change in pull request #12603: [MXNET-969] Fix buffer overflow in RNNOp

KellenSunderland commented on a change in pull request #12603: [MXNET-969] Fix buffer overflow in RNNOp
URL: https://github.com/apache/incubator-mxnet/pull/12603#discussion_r219314629
 
 

 ##########
 File path: src/operator/rnn-inl.h
 ##########
 @@ -576,7 +583,7 @@ class RNNOp : public Operator{
                        req[rnn_enum::kData],
                        req[rnn_enum::kParams],
                        req[rnn_enum::kState],
-                       req[rnn_enum::kStateCell],
+                       req_statecell,
 
 Review comment:
   Yeah, ternary is an option.  I can update.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services