You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "developerzohaib786 (via GitHub)" <gi...@apache.org> on 2026/01/21 15:02:04 UTC

[PR] feat(console): Make OAuth token URL configurable [polaris-tools]

developerzohaib786 opened a new pull request, #136:
URL: https://github.com/apache/polaris-tools/pull/136

   Fixes #98
   
   Make the OAuth token URL configurable via VITE_OAUTH_TOKEN_URL environment variable to support integration with 3rd party providers like Keycloak.
   
   Changes:
   - Use config.OAUTH_TOKEN_URL in auth.ts with fallback to default
   - Document VITE_OAUTH_TOKEN_URL in . env.example and README. md
   - Add Keycloak integration example and configuration guide
   - Update Dockerfile to include VITE_OAUTH_TOKEN_URL environment variable
   - Support both build-time and runtime configuration
   
   Defaults to '/api/catalog/v1/oauth/tokens' for backward compatibility.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(console): Make OAuth token URL configurable [polaris-tools]

Posted by "developerzohaib786 (via GitHub)" <gi...@apache.org>.
developerzohaib786 commented on code in PR #136:
URL: https://github.com/apache/polaris-tools/pull/136#discussion_r2713137655


##########
apprunner/maven-plugin/src/test/resources-its/org/apache/polaris/apprunner/maven/ITPolarisMavenPlugin/applicationIdSpecified/src/test/java/org/apache/polaris/appruner/maven/mavenit/ITSimulatingTestUsingThePlugin.java:
##########
@@ -1,48 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-package org.apache.polaris.apprunner.maven.mavenit;
-
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-
-import org.junit.jupiter.api.Test;
-import org.projectnessie.client.api.NessieApiV1;
-import org.projectnessie.client.http.HttpClientBuilder;
-import org.projectnessie.model.Branch;
-
-/**
- * This is not a test for the plugin itself, this is a test that is run BY the test for the plugin.
- */
-class ITSimulatingTestUsingThePlugin {

Review Comment:
   kindly have a look now. everything is good to go



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(console): Make OAuth token URL configurable [polaris-tools]

Posted by "binarycat0 (via GitHub)" <gi...@apache.org>.
binarycat0 commented on code in PR #136:
URL: https://github.com/apache/polaris-tools/pull/136#discussion_r2716229646


##########
console/docker/Dockerfile:
##########
@@ -13,22 +13,21 @@
 # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
-# under the License.
+# under the License. 

Review Comment:
   Extra whitespace



##########
console/docker/Dockerfile:
##########
@@ -1,7 +1,7 @@
 # Licensed to the Apache Software Foundation (ASF) under one
 # or more contributor license agreements.  See the NOTICE file
 # distributed with this work for additional information
-# regarding copyright ownership.  The ASF licenses this file
+# regarding copyright ownership.   The ASF licenses this file

Review Comment:
   Extra whitespace?



##########
console/docker/Dockerfile:
##########
@@ -13,22 +13,21 @@
 # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
-# under the License.
+# under the License. 
 
 # Build stage
-FROM registry.access.redhat.com/ubi9/nodejs-22-minimal:9.7-1767673763 AS builder
+FROM node:22-slim AS builder

Review Comment:
   AFAIK this image was used in purpose. 
   Please check this PR - https://github.com/apache/polaris-tools/commit/34e63e682b41b4ff9566c5db803d30e9fa73e15f



##########
console/docker/Dockerfile:
##########
@@ -13,22 +13,21 @@
 # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
-# under the License.
+# under the License. 
 
 # Build stage
-FROM registry.access.redhat.com/ubi9/nodejs-22-minimal:9.7-1767673763 AS builder
+FROM node:22-slim AS builder
 
-# Default environment variables (can be overridden at runtime)
+# Set default environment variables (can be overridden at runtime)
 ENV VITE_POLARIS_API_URL=http://polaris:8181
 ENV VITE_POLARIS_REALM=POLARIS
-ENV VITE_POLARIS_PRINCIPAL_SCOPE=PRINCIPAL_ROLE:ALL
-ENV VITE_OAUTH_TOKEN_URL=http://polaris:8181/api/catalog/v1/oauth/tokens
+ENV VITE_OAUTH_TOKEN_URL=
 ENV VITE_POLARIS_REALM_HEADER_NAME=Polaris-Realm
 
 WORKDIR /app
 
 # Copy package files
-COPY package.json ./
+COPY package. json ./

Review Comment:
   Extra whitespace



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(console): Make OAuth token URL configurable [polaris-tools]

Posted by "developerzohaib786 (via GitHub)" <gi...@apache.org>.
developerzohaib786 commented on PR #136:
URL: https://github.com/apache/polaris-tools/pull/136#issuecomment-3796816533

   > Hi @developerzohaib786, thank you for your effort and contribution.
   > 
   > I would like to inform you in advance that, as part of the work on another feature request (#125), I proposed a redesign of the current concept of using Polaris Console UI as a service for a single Apache Polaris server.
   > 
   > In the new design, Workspace is introduced as a separate entity that contains all the necessary configuration for connecting to an Apache Polaris instance, which will unblock the possibility to use Console UI as an instance for multiple Polaris servers / Realms.
   > 
   > A draft PR has already been created and is ready for testing: #138
   > 
   > Due to these upcoming changes, I assume that this PR and the related Issue may become outdated. Even if the changes are accepted, they will most likely be removed, since the server URL and auth endpoint configuration will be moved to the Workspace entity.
   
   i think if the changes will be removed or outdated by upcoming changes then let it be as i am preparing for Gsoc and this will be a great favour for me. 
   whatever the situation is please let me know.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(console): Make OAuth token URL configurable [polaris-tools]

Posted by "developerzohaib786 (via GitHub)" <gi...@apache.org>.
developerzohaib786 commented on PR #136:
URL: https://github.com/apache/polaris-tools/pull/136#issuecomment-3796391163

   ## implementation proof, this actualy fixes Issue #98
   
   ### what Issue #98 asked for
   > "The Token URL should be configurable to integration with 3rd party (like Keycloack)."
   > See: https://github.com/jbonofre/polaris-tools/tree/keycloak-support
   
   ### what my previous pull request did wrong
   - only added an environment variable `VITE_OAUTH_TOKEN_URL`
   - still couldn't support keycloak's different authentication flow
   - didn't allow users to choose auth type
   - changed Docker image (unrelated)
   - added whitespace issues
   
   ### what This pull request does right
   
   #### 1. follows reference implementation
   This matches @jbonofre's working implementation in the keycloak-support branch that was referenced in issue #98.
   
   #### 2. authentication type selector
   uusers can now choose between:
   - **iInternal (polaris)** - uses `/api/catalog/v1/oauth/tokens`
   - **external (keycloak)** - uses `/keycloak/realms/{realm}/protocol/openid-connect/token`
   
   #### 3. dynamic url rrouting
   The code now routes to different 0auth endpoints based on user selection:
   
   ```typescript
   if (authType === "keycloak") {
     if (!realm) {
       throw new Error("Keycloak realm is required for Keycloak authentication")
     }
     tokenUrl = 
   } else {
     tokenUrl = INTERNAL_TOKEN_URL // /api/catalog/v1/oauth/tokens
   }
   
   ## the login form showing the "Authentication Type" dropdown
   <img width="511" height="538" alt="fix-1" src="https://github.com/user-attachments/assets/ddb78b3f-5e10-4f9b-a6aa-63e990099a8a" />
   
   ## Showing the form fields with "Internal (Polaris)" is selected: Client ID, Client Secret, Polaris Realm
   <img width="490" height="538" alt="image" src="https://github.com/user-attachments/assets/05d6922a-4ade-4d6a-9af8-1e0765d46904" />
   
   ## Notice the new "Keycloak Realm" field appears
   <img width="506" height="602" alt="image" src="https://github.com/user-attachments/assets/8266058e-9aca-4fbf-a667-af21920b24fd" />
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(console): Make OAuth token URL configurable [polaris-tools]

Posted by "developerzohaib786 (via GitHub)" <gi...@apache.org>.
developerzohaib786 commented on PR #136:
URL: https://github.com/apache/polaris-tools/pull/136#issuecomment-3783863920

   > Thanks for the contribution and for taking the time to work on this PR β€” it’s appreciated.
   > 
   > I noticed that this change includes several updates that seem unrelated or redundant with respect to the main purpose of the PR. To help keep reviews focused and maintainable, could you please reduce the scope to only the changes strictly required for the intended fix/feature?
   > 
   > Since this repository is maintained under the Apache Polaris community, we also try to follow the Apache contribution guidelines closely. In particular, it would be great if you could align this PR with the code contribution guidelines described here: https://polaris.apache.org/community/contributing-guidelines/#code-contribution-guidelines
   > 
   > Narrowing the changeset and following these guidelines will make it much easier for the community to review and merge the contribution.
   > 
   > Thanks again for your effort, and please let us know if anything in the guidelines is unclear.
   
   if i am not wrong please confirm that i have to Revert to Red Hat UBI image??


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(console): Make OAuth token URL configurable [polaris-tools]

Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #136:
URL: https://github.com/apache/polaris-tools/pull/136#discussion_r2713037793


##########
apprunner/maven-plugin/src/test/resources-its/org/apache/polaris/apprunner/maven/ITPolarisMavenPlugin/applicationIdSpecified/src/test/java/org/apache/polaris/appruner/maven/mavenit/ITSimulatingTestUsingThePlugin.java:
##########
@@ -1,48 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-package org.apache.polaris.apprunner.maven.mavenit;
-
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-
-import org.junit.jupiter.api.Test;
-import org.projectnessie.client.api.NessieApiV1;
-import org.projectnessie.client.http.HttpClientBuilder;
-import org.projectnessie.model.Branch;
-
-/**
- * This is not a test for the plugin itself, this is a test that is run BY the test for the plugin.
- */
-class ITSimulatingTestUsingThePlugin {

Review Comment:
   Is this change related to OAuth in the console? πŸ˜… 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(console): Make OAuth token URL configurable [polaris-tools]

Posted by "developerzohaib786 (via GitHub)" <gi...@apache.org>.
developerzohaib786 commented on PR #136:
URL: https://github.com/apache/polaris-tools/pull/136#issuecomment-3796397460

   I am working on this pr and will resolve the conflicts and will remove the exta-spaces. it will be done about in an hour
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(console): Make OAuth token URL configurable [polaris-tools]

Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #136:
URL: https://github.com/apache/polaris-tools/pull/136#discussion_r2713157288


##########
apprunner/maven-plugin/src/test/resources-its/org/apache/polaris/apprunner/maven/ITPolarisMavenPlugin/applicationIdSpecified/src/test/java/org/apache/polaris/appruner/maven/mavenit/ITSimulatingTestUsingThePlugin.java:
##########
@@ -1,48 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-package org.apache.polaris.apprunner.maven.mavenit;
-
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-
-import org.junit.jupiter.api.Test;
-import org.projectnessie.client.api.NessieApiV1;
-import org.projectnessie.client.http.HttpClientBuilder;
-import org.projectnessie.model.Branch;
-
-/**
- * This is not a test for the plugin itself, this is a test that is run BY the test for the plugin.
- */
-class ITSimulatingTestUsingThePlugin {

Review Comment:
   Thanks for fixing the apprunner java code :slightly_smiling_face: 
   
   Unfortunately, I'm not familiar with Polaris UI for a review :sweat_smile: 
   
   CC: @binarycat0 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(console): Make OAuth token URL configurable [polaris-tools]

Posted by "developerzohaib786 (via GitHub)" <gi...@apache.org>.
developerzohaib786 commented on PR #136:
URL: https://github.com/apache/polaris-tools/pull/136#issuecomment-3796677029

   > Hi @developerzohaib786, thank you for your effort and contribution.
   > 
   > I would like to inform you in advance that, as part of the work on another feature request (#125), I proposed a redesign of the current concept of using Polaris Console UI as a service for a single Apache Polaris server.
   > 
   > In the new design, Workspace is introduced as a separate entity that contains all the necessary configuration for connecting to an Apache Polaris instance, which will unblock the possibility to use Console UI as an instance for multiple Polaris servers / Realms.
   > 
   > A draft PR has already been created and is ready for testing: #138
   > 
   > Due to these upcoming changes, I assume that this PR and the related Issue may become outdated. Even if the changes are accepted, they will most likely be removed, since the server URL and auth endpoint configuration will be moved to the Workspace entity.
   
   Would you like me to assign some work of upcoming design and logic? 
   We can discuss on slack channel or may be on email 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(console): Make OAuth token URL configurable [polaris-tools]

Posted by "binarycat0 (via GitHub)" <gi...@apache.org>.
binarycat0 commented on PR #136:
URL: https://github.com/apache/polaris-tools/pull/136#issuecomment-3796954488

   > Would you like me to assign some work of upcoming design and logic? We can discuss on slack channel or may be on email
   
   Hello! Thank you for your interest. I can't tell you much what to do next, but any contribution in testing in this PR https://github.com/apache/polaris-tools/pull/138 is very welcome.
   
   I know only if you have time and want to help you can join Apache Polaris Community Slack and ask for any advice there: https://join.slack.com/t/apache-polaris/shared_invite/zt-3niqssi92-s2IQMbe1jJ89ayZ4jQv2EQ


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(console): Make OAuth token URL configurable [polaris-tools]

Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #136:
URL: https://github.com/apache/polaris-tools/pull/136#discussion_r2713157288


##########
apprunner/maven-plugin/src/test/resources-its/org/apache/polaris/apprunner/maven/ITPolarisMavenPlugin/applicationIdSpecified/src/test/java/org/apache/polaris/appruner/maven/mavenit/ITSimulatingTestUsingThePlugin.java:
##########
@@ -1,48 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-package org.apache.polaris.apprunner.maven.mavenit;
-
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-
-import org.junit.jupiter.api.Test;
-import org.projectnessie.client.api.NessieApiV1;
-import org.projectnessie.client.http.HttpClientBuilder;
-import org.projectnessie.model.Branch;
-
-/**
- * This is not a test for the plugin itself, this is a test that is run BY the test for the plugin.
- */
-class ITSimulatingTestUsingThePlugin {

Review Comment:
   Thanks for fixing the migrator java code :slightly_smiling_face: 
   
   Unfortunately, I'm not familiar with Polaris UI for a review :sweat_smile: 
   
   CC: @binarycat0 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(console): Make OAuth token URL configurable [polaris-tools]

Posted by "developerzohaib786 (via GitHub)" <gi...@apache.org>.
developerzohaib786 commented on PR #136:
URL: https://github.com/apache/polaris-tools/pull/136#issuecomment-3794253764

   > > if i am not wrong please confirm that i have to Revert to Red Hat UBI image??
   > 
   > I consider this change as not meeting the main purpose of this PR. However, if you have concerns of using Red Hat UBI image it's better to open additional PR/Discussion issue.
   > 
   > Besides that please review your changes, it contains many additional whitespaces and non ASCII chars, all around the codebase.
   
   I will work on this pr in the following week


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(console): Make OAuth token URL configurable [polaris-tools]

Posted by "binarycat0 (via GitHub)" <gi...@apache.org>.
binarycat0 commented on PR #136:
URL: https://github.com/apache/polaris-tools/pull/136#issuecomment-3783975468

   > if i am not wrong please confirm that i have to Revert to Red Hat UBI image??
   
   I consider this change as not meeting the main purpose of this PR. 
   However, if you have concerns of using Red Hat UBI image it's better to open additional PR/Discussion issue.
   
   Besides that please review your changes, it contains many additional whitespaces and non ASCII chars, all around the codebase.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(console): Make OAuth token URL configurable [polaris-tools]

Posted by "developerzohaib786 (via GitHub)" <gi...@apache.org>.
developerzohaib786 commented on code in PR #136:
URL: https://github.com/apache/polaris-tools/pull/136#discussion_r2713091341


##########
apprunner/maven-plugin/src/test/resources-its/org/apache/polaris/apprunner/maven/ITPolarisMavenPlugin/applicationIdSpecified/src/test/java/org/apache/polaris/appruner/maven/mavenit/ITSimulatingTestUsingThePlugin.java:
##########
@@ -1,48 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-package org.apache.polaris.apprunner.maven.mavenit;
-
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-
-import org.junit.jupiter.api.Test;
-import org.projectnessie.client.api.NessieApiV1;
-import org.projectnessie.client.http.HttpClientBuilder;
-import org.projectnessie.model.Branch;
-
-/**
- * This is not a test for the plugin itself, this is a test that is run BY the test for the plugin.
- */
-class ITSimulatingTestUsingThePlugin {

Review Comment:
   I have only made changes in console. i don't know how and why this file changed πŸ˜‚
   let me restore this file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(console): Make OAuth token URL configurable [polaris-tools]

Posted by "binarycat0 (via GitHub)" <gi...@apache.org>.
binarycat0 commented on PR #136:
URL: https://github.com/apache/polaris-tools/pull/136#issuecomment-3796549728

   Hi @developerzohaib786, thank you for your effort and contribution.
   
   I would like to inform you in advance that, as part of the work on another feature request
   (https://github.com/apache/polaris-tools/issues/125), I proposed a redesign of the current concept of using Polaris Console UI as a service for a single Apache Polaris server.
   
   In the new design, Workspace is introduced as a separate entity that contains all the necessary configuration for connecting to an Apache Polaris instance, which will unblock the possibility to use Console UI as an instance for multiple Polaris servers / Realms.
   
   A draft PR has already been created and is ready for testing: https://github.com/apache/polaris-tools/pull/138
   
   Due to these upcoming changes, I assume that this PR and the related Issue may become outdated. Even if the changes are accepted, they will most likely be removed, since the server URL and auth endpoint configuration will be moved to the Workspace entity.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(console): Make OAuth token URL configurable [polaris-tools]

Posted by "developerzohaib786 (via GitHub)" <gi...@apache.org>.
developerzohaib786 commented on PR #136:
URL: https://github.com/apache/polaris-tools/pull/136#issuecomment-3796404678

   i have resolved the conflict issues. if i have done anything wrong while resolving conflicts let me know i will fix it later. 
   
   disclimer:  (as i have no experience in resolving the conflict issues on pull request and i asked for chatgpt about selection and then i resolved conflict issues)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org