You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/17 10:31:40 UTC

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #123: Fix parallel build

xiaoxiang781216 commented on a change in pull request #123: Fix parallel build
URL: https://github.com/apache/incubator-nuttx-apps/pull/123#discussion_r393581072
 
 

 ##########
 File path: examples/elf/tests/Makefile
 ##########
 @@ -100,19 +100,10 @@ ifneq ($(CONFIG_EXAMPLES_ELF_NOSTRIP),y)
 endif
 endif
 
-# Create the file system image directory
-
-$(FSIMG_DIR):
-	$(Q) mkdir $(FSIMG_DIR)
-
-# Populate the file system image directory
-
-populate:  $(FSIMG_DIR) build install
 
 Review comment:
   @masayuki2009 I think I found the root cause why object files get truncated:
   The populate target above trigger build and install run parallelly, and then gcc may compile the same source file twice concurrently.
   Please try my new PR, which modify three similar examples(elf/posix_spwan/sotest).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services