[jira] [Commented] (TINKERPOP-1760) OLAP compilation failing around ConnectiveStrategy

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144183#comment-16144183 ] 

ASF GitHub Bot commented on TINKERPOP-1760:
-------------------------------------------

GitHub user okram opened a pull request:

    https://github.com/apache/tinkerpop/pull/700

    TINKERPOP-1760: OLAP compilation failing around ConnectiveStrategy

    https://issues.apache.org/jira/browse/TINKERPOP-1760
    
    The more general problem was in `ComputerVerificationStrategy`. The problem was the nested traversals were being analyzed prior to full strategy compilation. The solution actually simplified the code a bit.
    
    ```
    gremlin> g = TinkerFactory.createModern().traversal().withComputer()
    ==>graphtraversalsource[tinkergraph[vertices:6 edges:6], graphcomputer]
    gremlin> g.V().where(out("created").and().out("knows")).values("name")
    ==>marko
    ```
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1760

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/700.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #700
    
----
commit c167d9ea779ee2229e5cd56e35a37a6fd225ffc9
Author: Marko A. Rodriguez <ok...@gmail.com>
Date:   2017-08-28T16:58:34Z

    tweaked how TraversalParent children are processed in ComputerVerifiationStrategy. Given the outside-in nature of Gremlin compilation, we were analyzing child traversals that were, in fact, not compiled yet. We now check for local star graph issues on a per traversal level. I can't believe we didn't run into other problems before this.

commit eb1be4dcfb6053ff65aae6805db61e6556c22384
Author: Marko A. Rodriguez <ok...@gmail.com>
Date:   2017-08-28T17:04:12Z

    updated CHANGELOG.

----


> OLAP compilation failing around ConnectiveStrategy
> --------------------------------------------------
>
>                 Key: TINKERPOP-1760
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1760
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: process
>    Affects Versions: 3.2.6
>            Reporter: Marko A. Rodriguez
>            Assignee: Marko A. Rodriguez
>
> {code}
> gremlin> g.V().where(out("created").and().out("knows")).values("name")
> Local traversals may not traverse past the local star-graph on GraphComputer: [VertexStep(OUT,[created],vertex), AndStep, VertexStep(OUT,[knows],vertex)]
> {code}
> This should compile to:
> {code}
> g.V().where(and(outE('created'),outE('knows'))).values('name')
> {code}
> BUG.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)