You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2022/01/31 05:14:50 UTC
[GitHub] [avro] KyleSchoonover opened a new pull request #1486: AVRO-3336 deprecate namespaceLookup field.
KyleSchoonover opened a new pull request #1486:
URL: https://github.com/apache/avro/pull/1486
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-3336
### Tests
- [ ] My PR does not need testing for this extremely good reason: removes obsolete code
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on a change in pull request #1486: AVRO-3336 deprecate namespaceLookup field.
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #1486:
URL: https://github.com/apache/avro/pull/1486#discussion_r795390972
##########
File path: lang/csharp/src/apache/main/CodeGen/CodeGen.cs
##########
@@ -92,6 +80,17 @@ public CodeGen()
this.Schemas = new List<Schema>();
this.Protocols = new List<Protocol>();
this.NamespaceMapping = new Dictionary<string, string>();
+ this.NamespaceLookup = new Dictionary<string, CodeNamespace>();
Review comment:
Do we need to pass `StringComparer.Ordinal` as in line 71 above ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #1486: AVRO-3336 deprecate namespaceLookup field.
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1486:
URL: https://github.com/apache/avro/pull/1486#issuecomment-1026673326
Thank you, @KyleSchoonover !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g merged pull request #1486: AVRO-3336 deprecate namespaceLookup field.
Posted by GitBox <gi...@apache.org>.
martin-g merged pull request #1486:
URL: https://github.com/apache/avro/pull/1486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] KyleSchoonover commented on a change in pull request #1486: AVRO-3336 deprecate namespaceLookup field.
Posted by GitBox <gi...@apache.org>.
KyleSchoonover commented on a change in pull request #1486:
URL: https://github.com/apache/avro/pull/1486#discussion_r795889559
##########
File path: lang/csharp/src/apache/main/CodeGen/CodeGen.cs
##########
@@ -92,6 +80,17 @@ public CodeGen()
this.Schemas = new List<Schema>();
this.Protocols = new List<Protocol>();
this.NamespaceMapping = new Dictionary<string, string>();
+ this.NamespaceLookup = new Dictionary<string, CodeNamespace>();
Review comment:
Yes good catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org