You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/05/30 23:16:26 UTC
Review Request 59664: Used `delete` for deleting copy constructor and
assignment operator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59664/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar and Vinod Kone.
Repository: mesos
Description
-------
This is for `Executor` and `Framework` class in slave.hpp.
Diffs
-----
src/slave/slave.hpp 77fb93abc701cd34b69c75b6219c219fdb784a67
Diff: https://reviews.apache.org/r/59664/diff/1/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 59664: Used `delete` for deleting copy constructor
and assignment operator.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59664/#review176468
-----------------------------------------------------------
Fix it, then Ship it!
ahh, seems like the `Executor`/`Framework` struct are here. Moving them all into a single review along with the `Slave` changes might be a good idea.
src/slave/slave.hpp
Lines 838-839 (original), 838-839 (patched)
<https://reviews.apache.org/r/59664/#comment249826>
Move it closer to the constructor now that it does not need to be private anymore?
- Anand Mazumdar
On May 30, 2017, 11:16 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59664/
> -----------------------------------------------------------
>
> (Updated May 30, 2017, 11:16 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is for `Executor` and `Framework` class in slave.hpp.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 77fb93abc701cd34b69c75b6219c219fdb784a67
>
>
> Diff: https://reviews.apache.org/r/59664/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>