You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cloud-fan (via GitHub)" <gi...@apache.org> on 2025/03/27 05:02:15 UTC

Re: [PR] [SPARK-51624] Propagate GetStructField metadata in CreateNamedStruct.dataType [spark]

cloud-fan commented on code in PR #50412:
URL: https://github.com/apache/spark/pull/50412#discussion_r2015643884


##########
sql/core/src/test/scala/org/apache/spark/sql/ComplexTypesSuite.scala:
##########
@@ -171,4 +171,18 @@ class ComplexTypesSuite extends QueryTest with SharedSparkSession {
     assert(df.schema == expectedSchema)
     checkAnswer(df, Seq(Row(Row(1, 2))))
   }
+
+  test("Propagate StructField metadata when doing CreateNamedStruct.dataType") {

Review Comment:
   ```suggestion
     test("SPARK-51624: Propagate StructField metadata when doing CreateNamedStruct.dataType") {
   ```



##########
sql/core/src/test/scala/org/apache/spark/sql/ComplexTypesSuite.scala:
##########
@@ -171,4 +171,18 @@ class ComplexTypesSuite extends QueryTest with SharedSparkSession {
     assert(df.schema == expectedSchema)
     checkAnswer(df, Seq(Row(Row(1, 2))))
   }
+
+  test("Propagate StructField metadata when doing CreateNamedStruct.dataType") {

Review Comment:
   ```suggestion
     test("SPARK-51624: Propagate StructField metadata in CreateNamedStruct.dataType") {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org